Skip to content

Commit e8c8d80

Browse files
committed
Improve safety and test coverage
1 parent b663663 commit e8c8d80

File tree

18 files changed

+1124
-959
lines changed

18 files changed

+1124
-959
lines changed

.github/workflows/CI.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,6 +313,13 @@ jobs:
313313
- name: List packages
314314
run: ls -R ./npm
315315
shell: bash
316+
- name: Give GitHub Actions access to ext-php-rs
317+
uses: webfactory/ssh-agent@v0.5.4
318+
with:
319+
ssh-private-key: ${{ secrets.SECRET_REPO_DEPLOY_KEY }}
320+
- name: Test crates
321+
shell: bash
322+
run: cargo test
316323
- name: Test bindings
317324
run: pnpm test
318325

@@ -381,7 +388,7 @@ jobs:
381388
- name: List packages
382389
run: ls -R ./npm
383390
shell: bash
384-
- name: Test bindings
391+
- name: Test crates and bindings
385392
uses: addnab/docker-run-action@v3
386393
with:
387394
image: ${{ steps.docker.outputs.IMAGE }}
@@ -392,6 +399,7 @@ jobs:
392399
libcurl4-openssl-dev autoconf libxml2-dev libsqlite3-dev \
393400
bison re2c libonig-dev
394401
402+
cargo test
395403
npm run test
396404
397405
publish:

.github/workflows/lint.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,11 @@ jobs:
4848
- name: Cargo fmt
4949
run: cargo fmt -- --check
5050

51-
# TODO: Clippy yells a lot. Need to clean things up before turning it on.
52-
5351
# Clippy needs access to install ext-php-rs
54-
# - name: Give GitHub Actions access to ext-php-rs
55-
# uses: webfactory/ssh-agent@v0.5.4
56-
# with:
57-
# ssh-private-key: ${{ secrets.SECRET_REPO_DEPLOY_KEY }}
52+
- name: Give GitHub Actions access to ext-php-rs
53+
uses: webfactory/ssh-agent@v0.5.4
54+
with:
55+
ssh-private-key: ${{ secrets.SECRET_REPO_DEPLOY_KEY }}
5856

59-
# - name: Clippy
60-
# run: cargo clippy
57+
- name: Clippy
58+
run: cargo clippy

0 commit comments

Comments
 (0)