improved log mock

Author: archmoj

src/traces/isosurface/convert.js

@@ -819,28 +819,40 @@ function generateIsosurfaceMesh(data) {
                             );
                         }
                     } else {
-                        if(e === 'x') indices = createRange(1, width - 1);
-                        if(e === 'y') indices = createRange(1, height - 1);
-                        if(e === 'z') indices = createRange(1, depth - 1);
+                        if(e === 'x') {
+                            indices = createRange(1, width - 1);
+                        } else if(e === 'y') {
+                            indices = createRange(1, height - 1);
+                        } else {
+                            indices = createRange(1, depth - 1);
+                        }
                     }
 
-                    if(e === 'x') drawSlicesX(activeStyle, indices, activeMin, activeMax);
-                    if(e === 'y') drawSlicesY(activeStyle, indices, activeMin, activeMax);
-                    if(e === 'z') drawSlicesZ(activeStyle, indices, activeMin, activeMax);
+                    if(e === 'x') {
+                        drawSlicesX(activeStyle, indices, activeMin, activeMax);
+                    } else if(e === 'y') {
+                        drawSlicesY(activeStyle, indices, activeMin, activeMax);
+                    } else {
+                        drawSlicesZ(activeStyle, indices, activeMin, activeMax);
+                    }
                 }
 
                 // draw caps
                 var cap = data.caps[e];
                 if(cap.show && cap.fill) {
                     setFill(cap.fill);
-                    if(e === 'x') drawSlicesX(activeStyle, [0, width - 1], activeMin, activeMax);
-                    if(e === 'y') drawSlicesY(activeStyle, [0, height - 1], activeMin, activeMax);
-                    if(e === 'z') drawSlicesZ(activeStyle, [0, depth - 1], activeMin, activeMax);
+                    if(e === 'x') {
+                        drawSlicesX(activeStyle, [0, width - 1], activeMin, activeMax);
+                    } else if(e === 'y') {
+                        drawSlicesY(activeStyle, [0, height - 1], activeMin, activeMax);
+                    } else {
+                        drawSlicesZ(activeStyle, [0, depth - 1], activeMin, activeMax);
+                    }
                 }
             }
         });
 
-        // remove vertices arrays (i.e. grid points) in case no faces was created created.
+        // remove vertices arrays (i.e. grid points) in case no face was created.
         if(numFaces === 0) {
             emptyVertices();
         }
@@ -853,7 +865,6 @@ function generateIsosurfaceMesh(data) {
         data.y = allYs;
         data.z = allZs;
         data.intensity = allVs;
-
     }
 
     voidMain();

test/image/mocks/gl3d_isosurface_log-axis_slices_surface-fill.json

@@ -1,12 +1,12 @@
 {
     "data": [{
         "type": "isosurface",
-        "colorscale": "Portland",
+        "colorscale": "Rainbow",
         "reversescale": false,
-        "surface": { "show": true, "fill": 0.8 },
+        "surface": { "show": true, "fill": 1 },
         "spaceframe": { "show": false },
         "slices": {
-            "x": { "show": true, "fill": 1, "locations": [0, -0.45, -0.9, -1.8] },
+            "x": { "show": true, "fill": 1, "locations": [-0.9, -0.6, 0] },
             "y": { "show": false },
             "z": { "show": true, "fill": 1 }
         },
@@ -19,10 +19,10 @@
             "show": true,
             "width": 4
         },
-        "x": [ -4.500, -4.050, -3.600, -3.150, -2.700, -2.250, -1.800, -1.350, -0.900, -0.450, 0.000, 0.450, 0.900, 1.350, 1.800, 2.250, 2.700, 3.150, 3.600, 4.050, 4.500 ],
-        "y": [ -4.500, -4.050, -3.600, -3.150, -2.700, -2.250, -1.800, -1.350, -0.900, -0.450, 0.000, 0.450, 0.900, 1.350, 1.800, 2.250, 2.700, 3.150, 3.600, 4.050, 4.500 ],
-        "z": [ 1.000, 1.450, 1.900, 2.350, 2.800, 3.250, 3.700, 4.150, 4.600, 5.050, 5.500, 5.950, 6.400, 6.850, 7.300, 7.750, 8.200, 8.650, 9.100, 9.550, 10.000 ],
-        "isomin": 250,
+        "x": [ -4.5, -4.05, -3.6, -3.15, -2.7, -2.25, -1.8, -1.35, -0.9, -0.45, 0, 0.45, 0.9, 1.35, 1.8, 2.25, 2.7, 3.15, 3.6, 4.05, 4.5 ],
+        "y": [ -4.5, -4.05, -3.6, -3.15, -2.7, -2.25, -1.8, -1.35, -0.9, -0.45, 0, 0.45, 0.9, 1.35, 1.8, 2.25, 2.7, 3.15, 3.6, 4.05, 4.5 ],
+        "z": [ 1, 1.45, 1.9, 2.35, 2.8, 3.25, 3.7, 4.15, 4.6, 5.05, 5.5, 5.95, 6.4, 6.85, 7.3, 7.75, 8.2, 8.65, 9.1, 9.55, 10 ],
+        "isomin": 200,
         "isomax": 500,
         "value": [
             750, 703, 660, 623, 590, 563, 540, 523, 510, 502, 500, 502, 510, 523, 540, 563, 590, 623, 660, 702, 750,
@@ -502,7 +502,7 @@
     }],
     "layout": {
         "title": {
-            "text": "Spherical isosurface trace on logarithmic axes with horizontal caps & slices as well as vertical slices on desired locations"
+            "text": "Spherical isosurface trace on logarithmic axes with horizontal caps & slices as well as 3 vertical slices on desired locations"
         },
         "width": 1200,
         "height": 900,
@@ -512,9 +512,9 @@
             "zaxis": { "nticks": 12, "type": "log", "title" : { "text": "Logarithmic axis" }},
             "camera": {
                 "eye": {
-                    "x": -1.5,
-                    "y": -1.0,
-                    "z": 0.25
+                    "x": 0.75,
+                    "y": -1.75,
+                    "z": 0.2
                 }
             }
         }