keep track of initial order - to handle chrome unstable sort in old versions

Author: archmoj

src/components/legend/get_legend_data.js

@@ -11,8 +11,10 @@ module.exports = function getLegendData(calcdata, opts) {
     var lgroupi = 0;
     var maxNameLength = 0;
     var i, j;
-
+    var initID = 0;
     function addOneItem(legendGroup, legendItem) {
+        legendItem._initID = initID++;
+
         // each '' legend group is treated as a separate group
         if(legendGroup === '' || !helpers.isGrouped(opts)) {
             // TODO: check this against fullData legendgroups?
@@ -78,6 +80,7 @@ module.exports = function getLegendData(calcdata, opts) {
         var B = b[0].trace;
         var delta = A.legendrank - B.legendrank;
         if(!delta) delta = A.index - B.index;
+        if(!delta) delta = a[0]._initID - b[0]._initID;
 
         return dir * delta;
     };

test/jasmine/tests/legend_test.js

@@ -283,22 +283,22 @@ describe('legend getLegendData', function() {
 
         expected = [
             [
-                [{trace: {
+                [{_initID: 0, trace: {
                     type: 'scatter',
                     visible: true,
                     legendgroup: 'group',
                     showlegend: true
 
                 }}],
-                [{trace: {
+                [{_initID: 2, trace: {
                     type: 'scatter',
                     visible: true,
                     legendgroup: 'group',
                     showlegend: true
                 }}]
             ],
             [
-                [{trace: {
+                [{_initID: 1, trace: {
                     type: 'bar',
                     visible: 'legendonly',
                     legendgroup: '',
@@ -341,20 +341,20 @@ describe('legend getLegendData', function() {
 
         expected = [
             [
-                [{trace: {
+                [{_initID: 0, trace: {
                     type: 'scatter',
                     visible: true,
                     legendgroup: '',
                     showlegend: true
 
                 }}],
-                [{trace: {
+                [{_initID: 1, trace: {
                     type: 'bar',
                     visible: 'legendonly',
                     legendgroup: '',
                     showlegend: true
                 }}],
-                [{trace: {
+                [{_initID: 2, trace: {
                     type: 'scatter',
                     visible: true,
                     legendgroup: '',
@@ -427,20 +427,20 @@ describe('legend getLegendData', function() {
 
         expected = [
             [
-                [{trace: {
+                [{_initID: 2, trace: {
                     type: 'box',
                     visible: true,
                     legendgroup: '',
                     showlegend: true
 
                 }}],
-                [{trace: {
+                [{_initID: 1, trace: {
                     type: 'bar',
                     visible: 'legendonly',
                     legendgroup: '',
                     showlegend: true
                 }}],
-                [{trace: {
+                [{_initID: 0, trace: {
                     type: 'scatter',
                     visible: true,
                     legendgroup: '',
@@ -483,22 +483,22 @@ describe('legend getLegendData', function() {
 
         expected = [
             [
-                [{trace: {
+                [{_initID: 2, trace: {
                     type: 'box',
                     visible: true,
                     legendgroup: 'group',
                     showlegend: true
 
                 }}],
-                [{trace: {
+                [{_initID: 0, trace: {
                     type: 'scatter',
                     visible: true,
                     legendgroup: 'group',
                     showlegend: true
                 }}]
             ],
             [
-                [{trace: {
+                [{_initID: 1, trace: {
                     type: 'bar',
                     visible: 'legendonly',
                     legendgroup: '',