Convert arrayOk attribute to calcdata in calc step#1257
Conversation
- making calc-transforms behave as desired on relayout (e.g. zoom) - this should also be a perf boost as trace array to calcdata is now called only in the calc as-opposed to the plot step (which is called more often e.g. on zoom)
|
I like the concept, but I'd really need to dig in and use it to fully appreciate and understand the true implications of the changes. One small note on carpet: the smoothing should debatably be view-dependent, which would mean it makes a big difference whether some parts are called in the plot or calc step. This sounds fine in that context; the only point being that I'm very interested in this despite not fully understanding the implications. |
|
Looks reasonable to me. Sometime we need to have a discussion about what an explicitly designed pipeline should look like in the context of updates; but until then seems like this kind of change (accumulating as many tests along the way as possible) is about the only way. |
|
will be part of |
This PR makes calc-transforms behave as desired on relayout (e.g. zoom).
Moreover, it should also be a perf boost as trace array to calcdata is now called only in the calc as opposed to the plot step (which is called more often e.g. on zoom).
Now, this PR moved around some pretty ancient code. I'm a little afraid about possible regressions. I'm not 100% confident in our test suite for the various
restylecall that depend onarraysToCalcdata, I'll dig into our test suites to verify.