Pubgears Header Bidding Adapter by Walexander · Pull Request #953 · prebid/Prebid.js

Walexander · 2017-01-25T18:01:07Z

Type of change

Description of change

Adapter and specs for Pubgears header bidder.

test parameters for validating bids

{
  bidder: 'pubgears',
  adUnitCode: 'id123/header-bid-tag-0',
  params: {
    publisherName: "integration",
    pubZone: "i.testpub.com/multibidder"
  }
}

walexander@mtheorydigital.com
official adapter submission

Other information

protonate · 2017-03-02T00:55:49Z

Is it possible to implement without using additional scripts?

protonate

Please see if you can remove additional scripts downloaded by the adapter.

protonate · 2017-03-07T21:33:06Z

Try rebasing onto current master branch, or if you prefer it may be easier to start with a new branch cut from current master branch and reintroduce your changes there.

mkendall07 · 2017-03-20T13:19:44Z

@Walexander looks like this needs to be rebased off master.

Walexander · 2017-03-28T14:23:31Z

The rebase has been completed. Apologies for the delay.

Walexander · 2017-03-28T14:25:34Z

It would be difficult to implement this without loading our external library. The adapter is built around receiving events from the script element itself. The code that publishes these events is implemented in the external library.

mkendall07 · 2017-03-30T20:05:21Z

src/adapters/pubgears.js

please remove all these extra new lines.

mkendall07 · 2017-03-30T20:06:21Z

src/adapters/pubgears.js

Please use the standard adLoader.loadScript instead

We use the script element to obtain the bid response data from our API. The adLoader.loadScript does not provide the element either via its return value or callback.

@Walexander can you give an example? That seems like a strange pattern to me.

Our API uses DOM events instead of method calls. The adapter registers event listeners with the script element here

API Documentation

mkendall07 · 2017-03-30T20:10:11Z

src/adapters/pubgears.js

You can use utils.replaceTokenInString for this functionality or a string template.

Thanks for the suggestion. This has been done.

also add unit test to insure tokens in creative template are expanded correctly

mkendall07 · 2017-04-18T18:27:55Z

@Walexander thanks for the updates. It looks like your adapter is adding 2 bid responses using the test params. See screenshot here:

You should only add a no_bid in case there isn't any demand. Please update.

Also - it doesn't appear that adUnitCode: 'id123/header-bid-tag-0', does anything? What's it's purpose?

mkendall07 · 2017-04-20T18:47:12Z

test/spec/adapters/pubgears_spec.js

 			expect(bidmanager.addBidResponse.calledOnce).to.be.ok
 		})

-		it('should not completely fucking fail', () => {


mkendall07 · 2017-05-02T18:18:47Z

LGTM

protonate · 2017-05-02T22:44:54Z

A note here that the use of script.dispatchEvent in tests is failing in some version of IE with "Object doesn't support this action". This is limited to unit tests in IE.

…built * 'master' of https://github.com/prebid/Prebid.js: (21 commits) add lodash as dependency (prebid#1174) fix size mapping for s2s (prebid#1175) Improve footer styling (prebid#1171) Bugfix: internal bids requested overwritten (prebid#1173) pre-release version bump Prebid 0.23.0 Release Yieldbot adapter - multiple requestBids per pageview (prebid#1146) Widespace adapter validate size fix (prebid#1140) Audience Network: bid when at least one valid slot size (prebid#1148) Quantcast adaptor (prebid#1063) AOL Adapter - ONE Mobile endpoint implemented. (prebid#1115) Prebid Server to Server (prebid#1165) Pubgears Header Bidding Adapter (prebid#953) remove old adloader#trackPixel (prebid#1159) added audit beacon to detect misuse of this bidder. Detects auctions… (prebid#1134) Bidfluence CDN endpoint URL update (prebid#1163) AdSupply adapter (prebid#1162) Sonobi Adapter - Enable size overrides (prebid#1141) Added an editorconfig file to match jshint and jssrc files. (prebid#1147) force cpm to be a number (prebid#1161) ...

* IDNT-928: Email hash support in uid2 * UID2 email hash issue * UID-SHA256 handling of both HEX and BASE64 output encoding * UID2: Warning message added instead of throwing Error * Merged conflicts * UID2: Warning message changed

matthewlane added the needs review label Jan 26, 2017

protonate self-assigned this Feb 1, 2017

protonate self-requested a review February 1, 2017 19:09

protonate suggested changes Mar 2, 2017

View reviewed changes

protonate added needs update and removed needs review labels Mar 2, 2017

Walexander force-pushed the master branch from 6b44b84 to ee61a48 Compare March 28, 2017 14:20

mkendall07 self-requested a review March 30, 2017 19:51

mkendall07 assigned mkendall07 and unassigned protonate Mar 30, 2017

mkendall07 suggested changes Mar 30, 2017

View reviewed changes

Will Alexander added 9 commits April 5, 2017 15:18

adapters/pubgears: initial commit of adapter, unit tests

ebc6db3

adapters/pubgears: new specs

09128b9

adapaters.json: added pubgears

92ef938

😎 style fixes

6aacb06

pubgears: support for non-array sizes bids

7635246

pubgears: use placementCode, not adUnitCode

baa9e91

pubgears style changes

249cc16

pubgears: remove vertical white-space

609da9d

pubgears: use utils.replaceInToken instead of own

26a058b

also add unit test to insure tokens in creative template are expanded correctly

Walexander force-pushed the master branch from ee61a48 to 26a058b Compare April 5, 2017 19:19

Will Alexander added 2 commits April 20, 2017 13:33

rename test ... ahem ...

56ddc4d

pubgears: send $0 bid as status code 2

5b29439

mkendall07 reviewed Apr 20, 2017

View reviewed changes

mkendall07 added needs review and removed needs update labels Apr 25, 2017

protonate added this to the Prebid 0.23.0 milestone May 2, 2017

mkendall07 approved these changes May 2, 2017

View reviewed changes

mkendall07 added the LGTM label May 2, 2017

protonate approved these changes May 2, 2017

View reviewed changes

protonate merged commit c17c483 into prebid:master May 2, 2017

protonate removed the needs review label May 2, 2017

Conversation

Walexander commented Jan 25, 2017

Type of change

Description of change

Other information

Uh oh!

protonate commented Mar 2, 2017

Uh oh!

protonate left a comment

Choose a reason for hiding this comment

Uh oh!

protonate commented Mar 7, 2017

Uh oh!

mkendall07 commented Mar 20, 2017

Uh oh!

Walexander commented Mar 28, 2017

Uh oh!

Walexander commented Mar 28, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkendall07 commented Apr 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkendall07 commented May 2, 2017

Uh oh!

protonate commented May 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments