Add native support for Criteo adapter

[Swiiip]

Type of change

• [ x] Feature

Description of change

This feature provides a new parameter for the Criteo adapter:
New parameter: nativeCallback
Type: javascript function
Parameter: criteo native json response

This callback is called on the returned json for native zones.

[Swiiip]

Hello guys, could we have an update on this PR please ?
Thanks

[mkendall07]

@Swiiip
Do you work for Criteo?
@icaroulle any thoughts on this?

[Swiiip]

@mkendall07 Yes I do work for Criteo

[ghost]

@Swiiip aka Hugo h.duthil@criteo.com is indeed working for Criteo. 😄
@mkendall07 Can you please review this change?

[mkendall07]

Ok thanks for the info guys. @matthewlane can you review?

[mkendall07]

@Swiiip
@icaroulle
Apologies on the delay for reviewing this. We are currently working on a pattern to support Native ad format in Prebid.js. We'd like to hold off on merging this until that is finalized and we can offer better universal support. I'll let you additional details soon. Thanks!

[mkendall07]

@Swiiip
Can you post an example function that would be passed to nativeCallback ?

[Swiiip]

@mkendall07

An example of native callback:

function(json) { 
    var li = $(".ccr-latest-post li")[0];
    var htmlcode = '';
    htmlcode += '<div class="ccr-thumbnail">';
    htmlcode += '<img src="'+ json.privacy.optout_image_url + '" style="width:19px;height:15px;position:absolute;right: 0px">';
    htmlcode += '<img src="'+ json.advertiser.logo.url + '" style="position: absolute; top: 0; left: 7px; padding: 3px 2px; line-height: 1; margin-left: -15px; font-size: 7px; letter-spacing: 1px; display: inline-block; text-transform: uppercase; -webkit-transform: rotate(-15deg); -moz-transform: rotate(-15deg); -ms-transform: rotate(-15deg); -o-transform: rotate(-15deg); transform: rotate(-15deg); width: 50% ">';
    htmlcode += '<img src="' + json.products[0].image.url + '" alt="Thumbnail 1" width="239px" height="191px" >';
    htmlcode += '<p><a href="' +  json.products[0].click_url + '">'+ "Go to: " + json.advertiser.domain +'</a></p>';
    htmlcode += '</div>';
    htmlcode += '<h4><a href="' + json.products[0].click_url + '">' + json.products[0].description.substring(0,40) + '</a></h4>';
    htmlcode += '<img src="' +json.products[0].viewurl + '" width="0px" height="0px" style="display:none" >';
    for (i in json.impression_pixels) {
        htmlcode += '<img src="' + json.impression_pixels[i].url + '" width="0px" height="0px" style="display:none" >';
    }							
    li.innerHTML = htmlcode;
    console.log(json);
}

[allanjun]

hi @mkendall07 any updates on this ?

[mkendall07]

please use string literals for constructing the templates. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

[Swiiip]

done 👍

[mkendall07]

@allanjun @Swiiip please rebase to resolve conflicts and update to use string templates then we can merge. Also would be great to get the API documented. Thanks

[Swiiip]

I updated the PR, we will provide updated documentation for the adapter once validated internally.

[muuki88]

we will provide updated documentation for the adapter once validated internally.

That's great news @Swiiip 😍 We currently read the code to figure out how to configure prebid, which is kinda awkward ;)

[mkendall07]

might consider indenting these lines.

[mkendall07]

@Swiiip it looks like the build is failing due to linting errors. Can you rebase 1 more time please and run eslint --fix on your file (or use your favorite editor to lint fix).

[Swiiip]

All set :)