From 23ad886c600485e7266dbcfe87fe54b08150335c Mon Sep 17 00:00:00 2001 From: Benjamin Rodenberg Date: Thu, 27 Feb 2025 17:19:33 +0100 Subject: [PATCH 1/4] Update Dockerfile --- tools/releasing/packaging/docker/Dockerfile | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/releasing/packaging/docker/Dockerfile b/tools/releasing/packaging/docker/Dockerfile index e3d6c3bf..2512a15c 100644 --- a/tools/releasing/packaging/docker/Dockerfile +++ b/tools/releasing/packaging/docker/Dockerfile @@ -18,11 +18,8 @@ RUN apt-get -qq update && apt-get -qq install \ USER precice -# Upgrade pip to newest version (pip version from 18.04 apt-get is outdated) -RUN python3 -m pip install --user --upgrade pip - # Rebuild image if force_rebuild after that command ARG PYTHON_BINDINGS_REF=develop # Builds the precice python bindings for python3 -RUN pip3 install --user git+https://github.com/precice/python-bindings.git@${PYTHON_BINDINGS_REF} +RUN pip3 install --break-system-packages git+https://github.com/precice/python-bindings.git@${PYTHON_BINDINGS_REF} From d2fac0dbb85adf69d92f1acd7c3ca81e0a778bd3 Mon Sep 17 00:00:00 2001 From: Benjamin Rodenberg Date: Wed, 12 Mar 2025 11:16:05 +0100 Subject: [PATCH 2/4] Delete .github/workflows/build-docker.yml --- .github/workflows/build-docker.yml | 54 ------------------------------ 1 file changed, 54 deletions(-) delete mode 100644 .github/workflows/build-docker.yml diff --git a/.github/workflows/build-docker.yml b/.github/workflows/build-docker.yml deleted file mode 100644 index f4b698de..00000000 --- a/.github/workflows/build-docker.yml +++ /dev/null @@ -1,54 +0,0 @@ -name: Update docker image - -on: - workflow_dispatch: # Trigger by hand from the UI - inputs: - branch: - type: choice - description: branch to build the image from - options: - - develop - push: - branches: - - develop - - -jobs: - build-and-release-docker-image: - name: Builds a dockerimage with the python bindings of preCICE - runs-on: ubuntu-latest - env: - docker_username: precice - steps: - - name: Set branch name for manual triggering - if: github.event_name == 'workflow_dispatch' - shell: bash - run: echo "BINDINGS_REF=${{ inputs.branch }}" >> $GITHUB_ENV - - name: Set branch name for "on pull request" triggering - if: github.event_name != 'pull_request' && github.event_name != 'workflow_dispatch' - shell: bash - run: echo "BINDINGS_REF=${{ github.ref_name }}" >> $GITHUB_ENV - - name: Set PRECICE_TAG and the TAG depending on branch - shell: bash - run: | - echo "PRECICE_TAG=${{ env.BINDINGS_REF == 'develop' && 'nightly' || env.BINDINGS_REF }}" >> "$GITHUB_ENV" - echo "TAG=${{ env.BINDINGS_REF }}" >> "$GITHUB_ENV" - echo "Building TAG: ${{ env.BINDINGS_REF }}" - - name: Checkout Repository - uses: actions/checkout@v2 - - name: Set up Docker Buildx - uses: docker/setup-buildx-action@v1 - - name: Login to DockerHub - uses: docker/login-action@v1 - with: - username: ${{ env.docker_username }} - password: ${{ secrets.DOCKERHUB_TOKEN }} - - name: Build and push Dockerfile - uses: docker/build-push-action@v2 - with: - push: true - file: "./tools/releasing/packaging/docker/Dockerfile" - tags: ${{ env.docker_username }}/python-bindings:${{ env.TAG }} - build-args: | - PRECICE_TAG=${{ env.PRECICE_TAG }} - PYTHON_BINDINGS_REF=${{ env.BINDINGS_REF }} From 1173f12a98b12cfa67ab21ef445c6f0de42a786d Mon Sep 17 00:00:00 2001 From: Benjamin Rodenberg Date: Wed, 12 Mar 2025 11:16:25 +0100 Subject: [PATCH 3/4] Delete tools/releasing/packaging/docker directory --- tools/releasing/packaging/docker/Dockerfile | 25 --------------------- 1 file changed, 25 deletions(-) delete mode 100644 tools/releasing/packaging/docker/Dockerfile diff --git a/tools/releasing/packaging/docker/Dockerfile b/tools/releasing/packaging/docker/Dockerfile deleted file mode 100644 index 2512a15c..00000000 --- a/tools/releasing/packaging/docker/Dockerfile +++ /dev/null @@ -1,25 +0,0 @@ -# Dockerfile to build a ubuntu image containing the installed Debian package of a release -ARG PRECICE_TAG=nightly -ARG from=precice/precice:${PRECICE_TAG} -FROM $from - -USER root -# Installing necessary dependencies -RUN apt-get -qq update && apt-get -qq install \ - apt-utils && \ - apt-get -qq install \ - software-properties-common \ - git \ - sudo \ - python3-dev \ - python3-pip \ - pkg-config && \ - rm -rf /var/lib/apt/lists/* - -USER precice - -# Rebuild image if force_rebuild after that command -ARG PYTHON_BINDINGS_REF=develop - -# Builds the precice python bindings for python3 -RUN pip3 install --break-system-packages git+https://github.com/precice/python-bindings.git@${PYTHON_BINDINGS_REF} From 956ab71bcab0dfdcff4d5218f690795929872fe9 Mon Sep 17 00:00:00 2001 From: Benjamin Rodenberg Date: Wed, 12 Mar 2025 16:54:52 +0100 Subject: [PATCH 4/4] Update CHANGELOG.md --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index aa26432a..1d8beab2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ All notable changes to this project will be documented in this file. +## latest + +* Discontinued maintainment of Docker image `precice/python-bindings`. Python packages should be installed using virtual environments instead. Please refer to `README.md` for further information. https://github.com/precice/python-bindings/pull/228 + ## v3.1.2 * Restrict to numpy < 2 for better compatibility with CI pipeline. https://github.com/precice/python-bindings/pull/213