-
Notifications
You must be signed in to change notification settings - Fork 646
Remove variant prop from KeybindingHint Chord component
#7214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 9b11466 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Updated the version of @primer/react to major and removed the variant prop from the KeybindingHint Chord component.
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
| .sort(compareLowercaseKeys) | ||
|
|
||
| export const Chord = ({keys, format = 'condensed', variant = 'normal', size = 'normal'}: KeybindingHintProps) => ( | ||
| export const Chord = ({keys, format = 'condensed', size = 'normal'}: KeybindingHintProps) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean the "variant" prop in KeyBindingHint will be a no-op? Not sure we should remove this without a major 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I did add a major changeset as it is breaking. FWIW I'm removing calls from dotcom in this PR but probably safe to put this in the next major anyway! https://github.com/github/github-ui/pull/7169
Closes https://github.com/github/primer/issues/6142
Removes the
variantprop and replaces it with Tooltip specific CSS. Primary was handled previously.Depends on https://github.com/github/github-ui/pull/7169 merging to unblock test failures.
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist