FilteredActionList: Add opt-in props to give more flexibility on focus management with aria-activedescendant

[TylerJDev]

Resolves issues in:

• https://github.com/github/accessibility-audits/issues/13705
• https://github.com/github/primer/issues/6124

Adds the following:

• Adds prop setInitialFocus which allows consumers of FilteredActionList/SelectPanel to disable the behavior where "focus" is set (via aria-activedescendant) on the first item when the the component is initially active.
  • Part of https://github.com/github/accessibility-audits/issues/13705
• Adds prop disableSelectOnHover that allows indirect "selection" on hover to be disabled via activeOnHover.
  • Part of https://github.com/github/primer/issues/6124

⚠️ This also includes a bump to @primer/behaviors to 1.9.0.

Changelog

New

• Adds props setInitialFocus and disableSelectOnHover

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: ff00f6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

[Copilot]

Pull request overview

This PR adds two new opt-in props to FilteredActionList (and by extension SelectPanel) to provide more flexibility in managing focus behavior with aria-activedescendant. The changes address accessibility issues and improve control over hover-based selection. The PR also bumps @primer/behaviors to version 1.9.0, which enables these new focus management features.

Key changes:

• Adds disableSelectOnHover prop to disable automatic selection on mouse hover
• Adds setInitialFocus prop to control initial focus behavior when the component becomes active
• Updates @primer/behaviors dependency from 1.8.2 to 1.9.0

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
packages/react/src/FilteredActionList/FilteredActionList.tsx	Implements the two new props (disableSelectOnHover and setInitialFocus) with corresponding focus zone configuration options and data attributes for items
packages/react/src/SelectPanel/SelectPanel.tsx	Adds disableSelectOnHover to SelectPanelBaseProps and passes it through to FilteredActionList
packages/react/src/SelectPanel/SelectPanel.dev.stories.tsx	Adds two new story examples demonstrating the usage of both new props
packages/react/package.json	Updates @primer/behaviors dependency to version 1.9.0
package-lock.json	Updates lock file entries for @primer/behaviors version 1.9.0
.changeset/many-planets-take.md	Documents the addition of disableSelectOnHover prop
.changeset/chubby-wombats-start.md	Documents the addition of setInitialFocus prop

Comments suppressed due to low confidence (2)

packages/react/src/FilteredActionList/FilteredActionList.tsx:347

• The data attribute naming is confusing. data-select-on-hover="true" when disableSelectOnHover is true suggests that selection on hover is enabled, when it's actually disabled. Consider either:

1. Renaming to data-disable-select-on-hover to match the prop name
2. Inverting the logic: data-select-on-hover={!disableSelectOnHover ? 'true' : 'false'}
3. Or simply: data-select-on-hover={String(!disableSelectOnHover)}

                        {...item}

packages/react/src/FilteredActionList/FilteredActionList.tsx:364

• The data attribute naming is confusing. data-select-on-hover="true" when disableSelectOnHover is true suggests that selection on hover is enabled, when it's actually disabled. Consider either:

1. Renaming to data-disable-select-on-hover to match the prop name
2. Inverting the logic: data-select-on-hover={!disableSelectOnHover ? 'true' : 'false'}
3. Or simply: data-select-on-hover={String(!disableSelectOnHover)}

                  renderItem={listProps.renderItem}