Skip to content

Conversation

@joshblack
Copy link
Member

Closes #

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2025

⚠️ No Changeset found

Latest commit: c785ecd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@lukasoppermann
Copy link
Contributor

lukasoppermann commented Dec 2, 2025

SelectPanel

@joshblack This is not an issue in SelectPanel but actually comes from a larger space between the label and the segementedControl.

The SegementedControl had a margin top 4px before which is missing now.

It was coming from this class:

.prc-FormControl-ControlVerticalLayout-wOp8f>:not(label)+*, .prc-FormControl-ControlVerticalLayout-wOp8f[data-has-label]>*+*
CleanShot 2025-12-02 at 13 19 25@2x

@primer primer deleted a comment from github-actions bot Dec 2, 2025
@primer primer deleted a comment from github-actions bot Dec 2, 2025
@lukasoppermann
Copy link
Contributor

lukasoppermann commented Dec 2, 2025

TextInput

The new TextInput is 2px wider. The actual input part is 2px wide (not the button or something). I have no idea where this is coming from.

ButtonGroup

The border radius on the buttons is not removed.

The button layer overwrites the reset in the buttonGroup layer:

CleanShot 2025-12-02 at 13 38 05@2x

If I change the layer from ButtonGroup to Button it works. I guess it is specificity because we have different layers. Is it really necessary to have one layer per component? Wouldn't primer.react.components be enough?

@primer primer deleted a comment from github-actions bot Dec 2, 2025
@primer primer deleted a comment from github-actions bot Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants