From c3e5c97b48e92a526cc009d155933929a7bf6941 Mon Sep 17 00:00:00 2001 From: Alok Date: Tue, 8 Jul 2025 14:26:14 +0530 Subject: [PATCH 1/2] fix: opt in check in bidding --- tools/preconf-rpc/sender/sender.go | 2 +- tools/preconf-rpc/service/service.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/preconf-rpc/sender/sender.go b/tools/preconf-rpc/sender/sender.go index 0048fa327..b3222be1d 100644 --- a/tools/preconf-rpc/sender/sender.go +++ b/tools/preconf-rpc/sender/sender.go @@ -439,7 +439,7 @@ func (t *TxSender) sendBid( big.NewInt(0), strings.TrimPrefix(txn.Raw, "0x"), &optinbidder.BidOpts{ - WaitForOptIn: optedInSlot, + WaitForOptIn: false, BlockNumber: uint64(price.BlockNumber), }, ) diff --git a/tools/preconf-rpc/service/service.go b/tools/preconf-rpc/service/service.go index 1ccef45cb..aff633d9c 100644 --- a/tools/preconf-rpc/service/service.go +++ b/tools/preconf-rpc/service/service.go @@ -223,7 +223,7 @@ func New(config *Config) (*Service, error) { handlers.RegisterMethods(rpcServer) mux := http.NewServeMux() - mux.HandleFunc("/health", func(w http.ResponseWriter, r *http.Request) { + mux.HandleFunc("GET /health", func(w http.ResponseWriter, r *http.Request) { if err := healthChecker.Health(); err != nil { http.Error(w, err.Error(), http.StatusServiceUnavailable) return From 667431485ad684153bd00e205bac9eec636a5324 Mon Sep 17 00:00:00 2001 From: Alok Date: Tue, 8 Jul 2025 19:53:57 +0530 Subject: [PATCH 2/2] fix: ignore error for no commitments --- tools/preconf-rpc/sender/sender.go | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/tools/preconf-rpc/sender/sender.go b/tools/preconf-rpc/sender/sender.go index b3222be1d..49f5198da 100644 --- a/tools/preconf-rpc/sender/sender.go +++ b/tools/preconf-rpc/sender/sender.go @@ -376,10 +376,7 @@ func (t *TxSender) sendBid( ) (bidResult, error) { timeToOptIn, err := t.bidder.Estimate() if err != nil { - t.logger.Error("Failed to estimate time to opt-in", "error", err) - if !errors.Is(err, optinbidder.ErrNoSlotInCurrentEpoch) && !errors.Is(err, optinbidder.ErrNoEpochInfo) { - return bidResult{}, err - } + t.logger.Warn("Failed to estimate time to opt-in", "error", err) // If we cannot estimate the time to opt-in, we assume a default value and // proceed with the bid process. The default value should be higher than // the typical block time to ensure we consider the next slot as a non-opt-in slot. @@ -479,12 +476,8 @@ BID_LOOP: } } } - if len(result.commitments) == 0 { - t.logger.Error("Bid completed with no commitments") - return bidResult{}, fmt.Errorf("bid completed with no commitments") - } t.logger.Info( - "Bid successful with commitments", + "Bid operation complete", "noOfProviders", result.noOfProviders, "noOfCommitments", len(result.commitments), "blockNumber", result.blockNumber,