From 4b724b1c921acdbec5f94ec95dd68bb76d14cd71 Mon Sep 17 00:00:00 2001 From: Benjamin Drung Date: Fri, 29 Oct 2021 11:54:29 +0200 Subject: [PATCH] Disable lnstat collector by default The new `lnstat` collector produces a high number of metrics, per-cpu, and results in approximately double the number of metrics previously scraped. For example, a typical server with 64 cores produces 3832 lnstat metrics compared to 4147 metrics for the remaining collectors. Therefore disable the `lnstat` collector by default. Signed-off-by: Benjamin Drung --- README.md | 2 +- collector/lnstat_linux.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 594941b522..b0efa1786d 100644 --- a/README.md +++ b/README.md @@ -106,7 +106,6 @@ filesystem | Exposes filesystem statistics, such as disk space used. | Darwin, D hwmon | Expose hardware monitoring and sensor data from `/sys/class/hwmon/`. | Linux infiniband | Exposes network statistics specific to InfiniBand and Intel OmniPath configurations. | Linux ipvs | Exposes IPVS status from `/proc/net/ip_vs` and stats from `/proc/net/ip_vs_stats`. | Linux -lnstat | Exposes stats from `/proc/net/stat/`. | Linux loadavg | Exposes load average. | Darwin, Dragonfly, FreeBSD, Linux, NetBSD, OpenBSD, Solaris mdadm | Exposes statistics about devices in `/proc/mdstat` (does nothing if no `/proc/mdstat` present). | Linux meminfo | Exposes memory statistics. | Darwin, Dragonfly, FreeBSD, Linux, OpenBSD @@ -199,6 +198,7 @@ drbd | Exposes Distributed Replicated Block Device statistics (to version 8.4) | ethtool | Exposes network interface information and network driver statistics equivalent to `ethtool`, `ethtool -S`, and `ethtool -i`. | Linux interrupts | Exposes detailed interrupts statistics. | Linux, OpenBSD ksmd | Exposes kernel and system statistics from `/sys/kernel/mm/ksm`. | Linux +lnstat | Exposes stats from `/proc/net/stat/`. | Linux logind | Exposes session counts from [logind](http://www.freedesktop.org/wiki/Software/systemd/logind/). | Linux meminfo\_numa | Exposes memory statistics from `/proc/meminfo_numa`. | Linux mountstats | Exposes filesystem statistics from `/proc/self/mountstats`. Exposes detailed NFS client statistics. | Linux diff --git a/collector/lnstat_linux.go b/collector/lnstat_linux.go index e5e13bf01b..bf67cfa570 100644 --- a/collector/lnstat_linux.go +++ b/collector/lnstat_linux.go @@ -30,7 +30,7 @@ type lnstatCollector struct { } func init() { - registerCollector("lnstat", defaultEnabled, NewLnstatCollector) + registerCollector("lnstat", defaultDisabled, NewLnstatCollector) } func NewLnstatCollector(logger log.Logger) (Collector, error) {