From 3b51518a51614ea87dc27b9f8a9487adc27f7fb9 Mon Sep 17 00:00:00 2001 From: Ben Kochie Date: Sat, 13 Jun 2020 10:57:25 +0200 Subject: [PATCH] Remove error wrapper from /sys/class/power_supply Don't wrap the error of `ioutil.ReadDir()` so that the error return can be tested with `os.IsNotExist()`. Fixes node_exporter log noise. ``` caller=collector.go:161 msg="collector failed" name=powersupplyclass duration_seconds=0.00079848 err="could not get power_supply class info: error obtaining power_supply class info: failed to list power supplies at \"/sys/class/power_supply\": open /sys/class/power_supply: no such file or directory" ``` Signed-off-by: Ben Kochie --- sysfs/class_power_supply.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysfs/class_power_supply.go b/sysfs/class_power_supply.go index d12e91341..dceec9ea5 100644 --- a/sysfs/class_power_supply.go +++ b/sysfs/class_power_supply.go @@ -110,7 +110,7 @@ func (fs FS) PowerSupplyClass() (PowerSupplyClass, error) { dirs, err := ioutil.ReadDir(path) if err != nil { - return nil, fmt.Errorf("failed to list power supplies at %q: %v", path, err) + return nil, err } psc := make(PowerSupplyClass, len(dirs))