From 35f5d8f56bd734000dd5995545e76e1f5f90394c Mon Sep 17 00:00:00 2001 From: jpy-git Date: Thu, 24 Mar 2022 23:11:53 +0000 Subject: [PATCH 1/2] Remove for brackets: Extra unit test --- tests/data/remove_for_brackets.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/data/remove_for_brackets.py b/tests/data/remove_for_brackets.py index c8d88abcc50..2e5dd1d81e6 100644 --- a/tests/data/remove_for_brackets.py +++ b/tests/data/remove_for_brackets.py @@ -14,6 +14,10 @@ for (k, v) in dfkasdjfldsjflkdsjflkdsjfdslkfjldsjfgkjdshgkljjdsfldgkhsdofudsfudsofajdslkfjdslkfjldisfjdffjsdlkfjdlkjjkdflskadjldkfjsalkfjdasj.items(): print(k, v) +# Multiple brackets +for ((((k, v)))) in d.items(): + print(k, v) + # output # Only remove tuple brackets after `for` for k, v in d.items(): @@ -38,3 +42,7 @@ dfkasdjfldsjflkdsjflkdsjfdslkfjldsjfgkjdshgkljjdsfldgkhsdofudsfudsofajdslkfjdslkfjldisfjdffjsdlkfjdlkjjkdflskadjldkfjsalkfjdasj.items() ): print(k, v) + +# Multiple brackets +for k, v in d.items(): + print(k, v) From a2d1d195bd0c43f15325ac5bf28d66d42ec19094 Mon Sep 17 00:00:00 2001 From: Joe Young <80432516+jpy-git@users.noreply.github.com> Date: Thu, 24 Mar 2022 23:34:50 +0000 Subject: [PATCH 2/2] Caveat on test case --- tests/data/remove_for_brackets.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/data/remove_for_brackets.py b/tests/data/remove_for_brackets.py index 2e5dd1d81e6..c8c4d96e02b 100644 --- a/tests/data/remove_for_brackets.py +++ b/tests/data/remove_for_brackets.py @@ -14,7 +14,8 @@ for (k, v) in dfkasdjfldsjflkdsjflkdsjfdslkfjldsjfgkjdshgkljjdsfldgkhsdofudsfudsofajdslkfjdslkfjldisfjdffjsdlkfjdlkjjkdflskadjldkfjsalkfjdasj.items(): print(k, v) -# Multiple brackets +# Multiple brackets (N.B. this only currently works due to the second pass. +# We should fix this to work in one pass. for ((((k, v)))) in d.items(): print(k, v) @@ -43,6 +44,7 @@ ): print(k, v) -# Multiple brackets +# Multiple brackets (N.B. this only currently works due to the second pass. +# We should fix this to work in one pass. for k, v in d.items(): print(k, v)