From b0f64a573447cf26ccd699223e74148d4416ac78 Mon Sep 17 00:00:00 2001
From: Ralf Anton Beier <ralf_beier@me.com>
Date: Sat, 25 Apr 2026 22:31:29 +0200
Subject: [PATCH] fix(tests/playwright): batch 5 stale-test cleanups
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Five Playwright tests had stale assertions that diverged from the
rendered output. None require a code change in rivet-cli or
rivet-core — these are pure test-code fixes.

- artifacts.spec.ts:49 — drop toContainText("flowchart LR") that
  raced mermaid.js's pre→SVG swap; keep only the SVG-presence check.
- documents.spec.ts:145 — tighten heading-IDs selector from
  article/main h2-h4 to .doc-body h2-h4 so it doesn't match the
  page-chrome <h2>{title}</h2> that has no id by design.
- rivet-delta.spec.ts:136 — tighten code-locator to
  :not(.language-mermaid) so it doesn't strict-mode-match both the
  mermaid source block and the standalone <code> row.
- rivet-delta.spec.ts:258 — page.goto("/") before setContent so
  <script src="/assets/mermaid.js"> resolves against the dev server
  instead of about:blank.
- rivet-delta.spec.ts:367 — add the missing
  ![alt](url) → <img> regex to mdToHtml so the svg-url image case
  isn't matched by the link regex.

The other 5 Playwright failures (artifacts.spec.ts:73,
filter-sort.spec.ts:225/253, serve-variant.spec.ts:25/67) are
addressed in separate PRs (serve middleware fix, decision-pending,
js.rs reload restoration) — see Mythos research agent triage.

Trace: skip

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 tests/playwright/artifacts.spec.ts   |  3 ---
 tests/playwright/documents.spec.ts   |  2 +-
 tests/playwright/rivet-delta.spec.ts | 15 ++++++++++++++-
 3 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/tests/playwright/artifacts.spec.ts b/tests/playwright/artifacts.spec.ts
index ad375bf..df7c449 100644
--- a/tests/playwright/artifacts.spec.ts
+++ b/tests/playwright/artifacts.spec.ts
@@ -57,9 +57,6 @@ test.describe("Artifacts", () => {
     const mermaidPre = page.locator("pre.mermaid");
     await expect(mermaidPre).toHaveCount(1);
 
-    // The source content must be there before mermaid.js runs.
-    await expect(mermaidPre).toContainText("flowchart LR");
-
     // mermaid.js replaces the block's contents with an <svg> on success.
     // Give it a moment to run — it's triggered by DOMContentLoaded and
     // htmx:afterSwap.  If rendering fails the pre block keeps its source.
diff --git a/tests/playwright/documents.spec.ts b/tests/playwright/documents.spec.ts
index 95badd7..28d1993 100644
--- a/tests/playwright/documents.spec.ts
+++ b/tests/playwright/documents.spec.ts
@@ -161,7 +161,7 @@ test.describe("Documents", () => {
     await page.goto(docLinks[0]);
     await waitForHtmx(page);
     const headings = await page
-      .locator("article h2, article h3, article h4, main h2, main h3, main h4")
+      .locator(".doc-body h2, .doc-body h3, .doc-body h4")
       .evaluateAll((els) =>
         els.map((el) => ({
           tag: el.tagName.toLowerCase(),
diff --git a/tests/playwright/rivet-delta.spec.ts b/tests/playwright/rivet-delta.spec.ts
index ad3b212..f301e21 100644
--- a/tests/playwright/rivet-delta.spec.ts
+++ b/tests/playwright/rivet-delta.spec.ts
@@ -65,6 +65,12 @@ function mdToHtml(md: string): string {
   html = html.replace(/`([^`]+)`/g, "<code>$1</code>");
   // Bold.
   html = html.replace(/\*\*([^*]+)\*\*/g, "<strong>$1</strong>");
+  // Images (must come before links — `![alt](url)` would otherwise be
+  // partly consumed by the link regex as `[alt](url)`).
+  html = html.replace(
+    /!\[([^\]]+)\]\(([^)]+)\)/g,
+    '<img alt="$1" src="$2">',
+  );
   // Links.
   html = html.replace(
     /\[([^\]]+)\]\(([^)]+)\)/g,
@@ -184,7 +190,11 @@ test.describe("rivet-delta PR-comment output", () => {
     await expect(
       page.locator("h2", { hasText: "Rivet artifact delta" }),
     ).toBeVisible();
-    await expect(page.locator("code", { hasText: "REQ-NEW-1" })).toBeVisible();
+    await expect(
+      page
+        .locator("code:not(.language-mermaid)", { hasText: "REQ-NEW-1" })
+        .first(),
+    ).toBeVisible();
     await expect(
       page.locator("details summary", { hasText: "Modified" }),
     ).toBeVisible();
@@ -283,6 +293,9 @@ test.describe("rivet-delta PR-comment output", () => {
 
     // Use the project's bundled mermaid (served by `rivet serve` at
     // /assets/mermaid.js) so the parser version matches production.
+    // Navigate first so <script src="/assets/mermaid.js"> resolves
+    // against the dev server instead of about:blank.
+    await page.goto("/");
     await page.setContent(`
       <!doctype html><html><body>
         <pre class="mermaid">${mermaidSrc