From 2dc1048a1f56d6148237bfbf68f2e1ea933e30d5 Mon Sep 17 00:00:00 2001 From: "Jason R. Coombs" Date: Mon, 26 Jun 2023 20:17:46 -0400 Subject: [PATCH 1/3] Specify encoding in fdopen. Fixes #195. --- execnet/gateway_base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/execnet/gateway_base.py b/execnet/gateway_base.py index 5db185fb..83c23e90 100644 --- a/execnet/gateway_base.py +++ b/execnet/gateway_base.py @@ -116,7 +116,7 @@ def start(self, func, args=()): def fdopen(self, fd, mode, bufsize=1): import os - return os.fdopen(fd, mode, bufsize) + return os.fdopen(fd, mode, bufsize, encoding="utf-8") def Lock(self): import threading From 0c4d991bdaf22484872a951f9c8cfed8c260b7cb Mon Sep 17 00:00:00 2001 From: "Jason R. Coombs" Date: Mon, 26 Jun 2023 20:23:39 -0400 Subject: [PATCH 2/3] Run tests with PYTHONWARNDEFAULTENCODING for visibility of warnings such as those reported in #195. --- tox.ini | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tox.ini b/tox.ini index 11f19831..2449698a 100644 --- a/tox.ini +++ b/tox.ini @@ -1,8 +1,11 @@ [tox] envlist=py{37,38,39,310,311,pypy37},docs,linting isolated_build = true + [testenv] usedevelop=true +setenv = + PYTHONWARNDEFAULTENCODING = 1 deps= pytest pytest-timeout From e2e0852ee698d0d671eafddaa493aa129f136b95 Mon Sep 17 00:00:00 2001 From: Bruno Oliveira Date: Tue, 4 Jul 2023 07:59:57 -0300 Subject: [PATCH 3/3] Add #195 to CHANGELOG and improve formatting/grammar --- CHANGELOG.rst | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 39e5be84..92108f1b 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -1,13 +1,15 @@ 2.0.0 (unreleased) ------------------ -* removed support for Python < 3.7 - * apply pyupgrade --py37-plus - * minimal mypy fixes and python2 support code drop -* migrate packaging to hatch -* drop deprecated apis of old makegateway names -* Removed ``py`` testing dependency +* Removed support for Python < 3.7. + - Applied ``pyupgrade --py37-plus``. + - Minimal ``mypy`` fixes and dropped Python 2 support code. + +* Migrated packaging to ``hatch``. +* Dropped deprecated APIs of old makegateway names. +* Removed ``py`` testing dependency. +* Explicitly pass ``encoding`` when opening files in the gateway to get rid of warnings when using ``PYTHONWARNDEFAULTENCODING=1`` (#195). 1.9.0 (2021-06-13)