From 4a213f74966c6f36d3353d5188ae1e7cb7a80b72 Mon Sep 17 00:00:00 2001 From: ethicnology Date: Mon, 25 Aug 2025 09:40:44 -0400 Subject: [PATCH 1/2] fix: add missing field version and description and remove version from account struct --- src/lib.rs | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/lib.rs b/src/lib.rs index 64422a7..e5aa91b 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -6,8 +6,12 @@ use serde::{Deserialize, Serialize}; #[derive(Debug, Serialize, Deserialize)] pub struct Backup { + #[serde(skip_serializing_if = "Option::is_none")] + pub version: Option, #[serde(skip_serializing_if = "Option::is_none")] pub name: Option, + #[serde(skip_serializing_if = "Option::is_none")] + pub description: Option, pub accounts: Vec, pub network: Network, /// App proprietary metadata (settings, configuration, etc..) @@ -17,10 +21,10 @@ pub struct Backup { #[derive(Debug, Serialize, Deserialize)] pub struct Account { - #[serde(skip_serializing_if = "Option::is_none")] - pub version: Option, #[serde(skip_serializing_if = "Option::is_none")] pub name: Option, + #[serde(skip_serializing_if = "Option::is_none")] + pub description: Option, pub descriptor: miniscript::Descriptor, pub active: bool, pub receive_index: Option, @@ -44,8 +48,8 @@ pub struct Account { impl Account { pub fn new(descriptor: miniscript::Descriptor) -> Self { Self { - version: None, name: None, + description: None, descriptor, active: true, receive_index: None, From 3ee75b03dee6cda2aa24627dbda76207a13352a9 Mon Sep 17 00:00:00 2001 From: ethicnology Date: Mon, 25 Aug 2025 09:43:30 -0400 Subject: [PATCH 2/2] feat: add optional `created_at` field to Backup struct and update README --- README.md | 2 +- src/lib.rs | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index bb17214..004d349 100644 --- a/README.md +++ b/README.md @@ -34,7 +34,7 @@ JSON object representing the backup structure. This object includes wallet-level metadata, multiple accounts, and associated key data. ### Wallet Backup Structure - +- `created_at`: Optional timestamp indicating the backup creation time - `version`: Optionnal version of the backup format - `name`: Optional wallet name - `description`: Optional wallet description diff --git a/src/lib.rs b/src/lib.rs index e5aa91b..00a2b35 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -6,6 +6,8 @@ use serde::{Deserialize, Serialize}; #[derive(Debug, Serialize, Deserialize)] pub struct Backup { + #[serde(skip_serializing_if = "Option::is_none")] + pub created_at: Option, #[serde(skip_serializing_if = "Option::is_none")] pub version: Option, #[serde(skip_serializing_if = "Option::is_none")]