From 3db44e5f5a552e2a2efee544b7ef5dd8d56f6c46 Mon Sep 17 00:00:00 2001 From: Todd Leonhardt Date: Thu, 10 Aug 2017 13:17:01 -0400 Subject: [PATCH] The default buffer size is fine for 99% of pipe operations Removed the complexity of a member variable which would be unnecessary for the vast majority of applications. If users have an application with atypical requirements, they are free to override the default. --- cmd2.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/cmd2.py b/cmd2.py index 24130f325..c688be9d6 100755 --- a/cmd2.py +++ b/cmd2.py @@ -545,11 +545,6 @@ def __init__(self, completekey='tab', stdin=None, stdout=None, use_ipython=False # Used when piping command output to a shell command self.pipe_proc = None - # Size of the stdin/stdout buffers used when piping command output to a shell command via self.stdout. - # This should be increased in cases where large amounts of data are expected to be piped to the shell - # to prevent blocking when writing to self.stdout. - self._pipe_buffer_size = io.DEFAULT_BUFFER_SIZE - # ----- Methods related to presenting output to the user ----- @property @@ -816,9 +811,9 @@ def _redirect_output(self, statement): # Open each side of the pipe and set stdout accordingly # noinspection PyTypeChecker - self.stdout = io.open(write_fd, write_mode, buffering=self._pipe_buffer_size) + self.stdout = io.open(write_fd, write_mode) # noinspection PyTypeChecker - subproc_stdin = io.open(read_fd, read_mode, buffering=self._pipe_buffer_size) + subproc_stdin = io.open(read_fd, read_mode) # We want Popen to raise an exception if it fails to open the process. Thus we don't set shell to True. try: