From f1abb979b854275b2b6626371bca50058b82bafb Mon Sep 17 00:00:00 2001 From: Devansh Baghla Date: Sat, 6 Sep 2025 22:52:39 +0530 Subject: [PATCH 1/3] Use self.type2test in list_tests.CommonTest --- Lib/test/list_tests.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Lib/test/list_tests.py b/Lib/test/list_tests.py index 68d6bad2094268..e76f79c274e744 100644 --- a/Lib/test/list_tests.py +++ b/Lib/test/list_tests.py @@ -32,13 +32,13 @@ def test_init(self): self.assertEqual(a, b) def test_getitem_error(self): - a = [] + a = self.type2test([]) msg = "list indices must be integers or slices" with self.assertRaisesRegex(TypeError, msg): a['a'] def test_setitem_error(self): - a = [] + a = self.type2test([]) msg = "list indices must be integers or slices" with self.assertRaisesRegex(TypeError, msg): a['a'] = "python" @@ -561,7 +561,7 @@ def test_constructor_exception_handling(self): class F(object): def __iter__(self): raise KeyboardInterrupt - self.assertRaises(KeyboardInterrupt, list, F()) + self.assertRaises(KeyboardInterrupt, self.type2test, F()) def test_exhausted_iterator(self): a = self.type2test([1, 2, 3]) From fb654a319774a0c5b2fd51e1ca5835d3097f3449 Mon Sep 17 00:00:00 2001 From: Devansh Baghla Date: Sat, 6 Sep 2025 23:09:37 +0530 Subject: [PATCH 2/3] gh-138584: Add NEWS entry for missing type2test in list_tests --- .../next/Tests/2025-09-06-21-50-00.gh-issue-138584.XyZ9Ab.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 Misc/NEWS.d/next/Tests/2025-09-06-21-50-00.gh-issue-138584.XyZ9Ab.rst diff --git a/Misc/NEWS.d/next/Tests/2025-09-06-21-50-00.gh-issue-138584.XyZ9Ab.rst b/Misc/NEWS.d/next/Tests/2025-09-06-21-50-00.gh-issue-138584.XyZ9Ab.rst new file mode 100644 index 00000000000000..163a5476cbe265 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2025-09-06-21-50-00.gh-issue-138584.XyZ9Ab.rst @@ -0,0 +1 @@ +gh-138584: Fixed list_tests.CommonTest to use type2test in test_getitem_error, test_setitem_error, and test_constructor_exception_handling in Lib/tests/list_tests.py. From d1c4a2af1445453ee6e85d6bcbe9e174e60c5652 Mon Sep 17 00:00:00 2001 From: Devansh Baghla Date: Sat, 6 Sep 2025 23:18:08 +0530 Subject: [PATCH 3/3] Remove NEWS entry for missing type2test in list_tests --- .../next/Tests/2025-09-06-21-50-00.gh-issue-138584.XyZ9Ab.rst | 1 - 1 file changed, 1 deletion(-) delete mode 100644 Misc/NEWS.d/next/Tests/2025-09-06-21-50-00.gh-issue-138584.XyZ9Ab.rst diff --git a/Misc/NEWS.d/next/Tests/2025-09-06-21-50-00.gh-issue-138584.XyZ9Ab.rst b/Misc/NEWS.d/next/Tests/2025-09-06-21-50-00.gh-issue-138584.XyZ9Ab.rst deleted file mode 100644 index 163a5476cbe265..00000000000000 --- a/Misc/NEWS.d/next/Tests/2025-09-06-21-50-00.gh-issue-138584.XyZ9Ab.rst +++ /dev/null @@ -1 +0,0 @@ -gh-138584: Fixed list_tests.CommonTest to use type2test in test_getitem_error, test_setitem_error, and test_constructor_exception_handling in Lib/tests/list_tests.py.