From d3c30b448737d5515684f4ae4a61f400429a8d25 Mon Sep 17 00:00:00 2001 From: Zackery Spytz Date: Fri, 21 Sep 2018 00:09:48 -0600 Subject: [PATCH] bpo-34735: Fix a memory leak in Modules/timemodule.c (GH-9418) There was a missing PyMem_Free(format) in time_strftime(). (cherry picked from commit 91e6c8717b7dcbcc46b189509de5f2d335819f37) Co-authored-by: Zackery Spytz --- .../Core and Builtins/2018-09-19-06-57-34.bpo-34735.-3mrSJ.rst | 1 + Modules/timemodule.c | 1 + 2 files changed, 2 insertions(+) create mode 100644 Misc/NEWS.d/next/Core and Builtins/2018-09-19-06-57-34.bpo-34735.-3mrSJ.rst diff --git a/Misc/NEWS.d/next/Core and Builtins/2018-09-19-06-57-34.bpo-34735.-3mrSJ.rst b/Misc/NEWS.d/next/Core and Builtins/2018-09-19-06-57-34.bpo-34735.-3mrSJ.rst new file mode 100644 index 00000000000000..8de08ec386374e --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2018-09-19-06-57-34.bpo-34735.-3mrSJ.rst @@ -0,0 +1 @@ +Fix a memory leak in Modules/timemodule.c. Patch by Zackery Spytz. diff --git a/Modules/timemodule.c b/Modules/timemodule.c index 05c4cbcb9c81d2..f66f098740b295 100644 --- a/Modules/timemodule.c +++ b/Modules/timemodule.c @@ -654,6 +654,7 @@ time_strftime(PyObject *self, PyObject *args) if (outbuf[1] == L'y' && buf.tm_year < 0) { PyErr_SetString(PyExc_ValueError, "format %y requires year >= 1900 on AIX"); + PyMem_Free(format); return NULL; } }