From da458ccb12c04fba4fced6d93be1018c45fd0f9a Mon Sep 17 00:00:00 2001 From: Giorgos Papoutsakis Date: Thu, 18 Apr 2024 19:13:48 +0300 Subject: [PATCH 1/2] Update CONTRIBUTING.md to include commands for Windows --- CONTRIBUTING.md | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 46292c301406a..42535b1bf4029 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -30,15 +30,22 @@ cd mypy #### (3) Create then activate a virtual environment ```bash -# On Windows, the commands may be slightly different. For more details, see -# https://docs.python.org/3/library/venv.html#creating-virtual-environments python3 -m venv venv source venv/bin/activate ``` +```bash +# For Windows use +python -m venv venv +. venv/Scripts/activate + +# For more details, see https://docs.python.org/3/library/venv.html#creating-virtual-environments +``` + #### (4) Install the test requirements and the project ```bash +# On Windows, use python instead of python3 python3 -m pip install -r test-requirements.txt python3 -m pip install -e . hash -r # This resets shell PATH cache, not necessary on Windows From 5a92e3a409774b1aae7f5cef98795a73db3ed5d6 Mon Sep 17 00:00:00 2001 From: Shantanu <12621235+hauntsaninja@users.noreply.github.com> Date: Sun, 21 Apr 2024 22:57:28 -0700 Subject: [PATCH 2/2] Update CONTRIBUTING.md --- CONTRIBUTING.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 42535b1bf4029..a5d339330a75a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -45,9 +45,8 @@ python -m venv venv #### (4) Install the test requirements and the project ```bash -# On Windows, use python instead of python3 -python3 -m pip install -r test-requirements.txt -python3 -m pip install -e . +python -m pip install -r test-requirements.txt +python -m pip install -e . hash -r # This resets shell PATH cache, not necessary on Windows ```