Enable pyright for all Python 3 stubs (#5597)

* pyright: disable reportUnknownParameterType

Unknown parameter types are preferred over Any annotations for
incomplete stubs. Especially larger stubs are expected to be
incomplete for some time and it would be a shame to lose the
other pyright warnings for those stubs.

* Also disable reportUnknownVariableType

Fix problems with tkinter

* Disable reportUnknownMemberType

Fix pyright problems

Author: srittau

pyrightconfig.json

@@ -17,31 +17,7 @@
         "stubs/pymssql",
         "stubs/Routes",
         "stubs/scribe",
-        "stubs/tornado",
-        // Modules that are incomplete in some way.
-        "stdlib/sqlite3/dbapi2.pyi",
-        "stdlib/tkinter",
-        "stdlib/xml/dom",
-        "stdlib/xml/sax",
-        "stubs/backports",
-        "stubs/backports_abc",
-        "stubs/boto",
-        "stubs/cryptography",
-        "stubs/docutils",
-        "stubs/Flask",
-        "stubs/Jinja2",
-        "stubs/Markdown",
-        "stubs/paramiko",
-        "stubs/protobuf",
-        "stubs/PyMySQL",
-        "stubs/python-dateutil",
-        "stubs/pyvmomi",
-        "stubs/PyYAML",
-        "stubs/redis",
-        "stubs/requests",
-        "stubs/simplejson",
-        "stubs/waitress",
-        "stubs/Werkzeug"
+        "stubs/tornado"
     ],
     "typeCheckingMode": "basic",
     "strictListInference": true,
@@ -70,11 +46,8 @@
     "reportIncompatibleMethodOverride": "error",
     "reportIncompatibleVariableOverride": "error",
     "reportInvalidStringEscapeSequence": "error",
-    "reportUnknownParameterType": "error",
     "reportUnknownArgumentType": "error",
     "reportUnknownLambdaType": "error",
-    "reportUnknownVariableType": "error",
-    "reportUnknownMemberType": "error",
     "reportMissingTypeArgument": "error",
     "reportUndefinedVariable": "error",
     "reportUnboundVariable": "error",

stdlib/tkinter/__init__.pyi

@@ -164,10 +164,11 @@ class EventType(str, Enum):
     VirtualEvent: str = ...
     Visibility: str = ...
 
+_W = TypeVar("_W", bound="Misc")
 # Events considered covariant because you should never assign to event.widget.
-_W = TypeVar("_W", covariant=True, bound="Misc")
+_W_co = TypeVar("_W_co", covariant=True, bound="Misc")
 
-class Event(Generic[_W]):
+class Event(Generic[_W_co]):
     serial: int
     num: int
     focus: bool
@@ -185,7 +186,7 @@ class Event(Generic[_W]):
     keysym: str
     keysym_num: int
     type: EventType
-    widget: _W
+    widget: _W_co
     delta: int
 
 def NoDefaultRoot(): ...

stdlib/tkinter/font.pyi

@@ -1,6 +1,6 @@
 import sys
 import tkinter
-from typing import Any, List, Optional, Tuple, TypeVar, Union, overload
+from typing import Any, Optional, Tuple, Union, overload
 from typing_extensions import Literal, TypedDict
 
 NORMAL: Literal["normal"]

stdlib/tkinter/scrolledtext.pyi

@@ -1,4 +1,4 @@
-from tkinter import Frame, Grid, Misc, Pack, Place, Scrollbar, Text
+from tkinter import Frame, Misc, Scrollbar, Text
 from typing import Any, Optional
 
 # The methods from Pack, Place, and Grid are dynamically added over the parent's impls

stdlib/tkinter/ttk.pyi

@@ -2,7 +2,7 @@ import _tkinter
 import sys
 import tkinter
 from tkinter.font import _FontDescription
-from typing import Any, Callable, Dict, List, Optional, Tuple, Union, overload
+from typing import Any, Callable, Dict, Optional, Tuple, Union, overload
 from typing_extensions import Literal, TypedDict
 
 def tclobjs_to_py(adict): ...

stubs/Jinja2/jinja2/utils.pyi

@@ -10,15 +10,15 @@ concat: Any
 
 _CallableT = TypeVar("_CallableT", bound=Callable[..., Any])
 
-class _ContextFunction(Protocol[_CallableT]):
+class _ContextFunction(Protocol[_CallableT]):  # type: ignore
     contextfunction: Literal[True]
     __call__: _CallableT
 
-class _EvalContextFunction(Protocol[_CallableT]):
+class _EvalContextFunction(Protocol[_CallableT]):  # type: ignore
     evalcontextfunction: Literal[True]
     __call__: _CallableT
 
-class _EnvironmentFunction(Protocol[_CallableT]):
+class _EnvironmentFunction(Protocol[_CallableT]):  # type: ignore
     environmentfunction: Literal[True]
     __call__: _CallableT
 

stubs/Markdown/markdown/blockparser.pyi

@@ -1,6 +1,6 @@
-from typing import Any
+from typing import Any, List
 
-class State(list):
+class State(List[Any]):
     def set(self, state) -> None: ...
     def reset(self) -> None: ...
     def isstate(self, state): ...

stubs/Markdown/markdown/blockprocessors.pyi

@@ -17,42 +17,42 @@ class BlockProcessor:
 class ListIndentProcessor(BlockProcessor):
     ITEM_TYPES: Any
     LIST_TYPES: Any
-    INDENT_RE: Pattern
+    INDENT_RE: Pattern[str]
     def __init__(self, *args) -> None: ...
     def create_item(self, parent, block) -> None: ...
     def get_level(self, parent, block): ...
 
 class CodeBlockProcessor(BlockProcessor): ...
 
 class BlockQuoteProcessor(BlockProcessor):
-    RE: Pattern
+    RE: Pattern[str]
     def clean(self, line): ...
 
 class OListProcessor(BlockProcessor):
     TAG: str = ...
     STARTSWITH: str = ...
     LAZY_OL: bool = ...
     SIBLING_TAGS: Any
-    RE: Pattern
-    CHILD_RE: Pattern
-    INDENT_RE: Pattern
+    RE: Pattern[str]
+    CHILD_RE: Pattern[str]
+    INDENT_RE: Pattern[str]
     def __init__(self, parser) -> None: ...
     def get_items(self, block): ...
 
 class UListProcessor(OListProcessor):
     TAG: str = ...
-    RE: Pattern
+    RE: Pattern[str]
     def __init__(self, parser) -> None: ...
 
 class HashHeaderProcessor(BlockProcessor):
-    RE: Pattern
+    RE: Pattern[str]
 
 class SetextHeaderProcessor(BlockProcessor):
-    RE: Pattern
+    RE: Pattern[str]
 
 class HRProcessor(BlockProcessor):
     RE: str = ...
-    SEARCH_RE: Pattern
+    SEARCH_RE: Pattern[str]
     match: Any
 
 class EmptyBlockProcessor(BlockProcessor): ...

stubs/Markdown/markdown/extensions/abbr.pyi

@@ -4,7 +4,7 @@ from markdown.blockprocessors import BlockProcessor
 from markdown.extensions import Extension
 from markdown.inlinepatterns import InlineProcessor
 
-ABBR_REF_RE: Pattern
+ABBR_REF_RE: Pattern[str]
 
 class AbbrExtension(Extension): ...
 class AbbrPreprocessor(BlockProcessor): ...

stubs/Markdown/markdown/extensions/admonition.pyi

@@ -6,9 +6,9 @@ from markdown.extensions import Extension
 class AdmonitionExtension(Extension): ...
 
 class AdmonitionProcessor(BlockProcessor):
-    CLASSNAME: str = ...
-    CLASSNAME_TITLE: str = ...
-    RE: Pattern
+    CLASSNAME: str
+    CLASSNAME_TITLE: str
+    RE: Pattern[str]
     RE_SPACES: Any
     def get_class_and_title(self, match): ...