From 9b8c56188978db48cd250de105f1e22671facc34 Mon Sep 17 00:00:00 2001 From: AlexWaygood Date: Tue, 21 Nov 2023 14:03:19 +0000 Subject: [PATCH 1/3] Improve a few dataclass reprs in stubsabot --- scripts/stubsabot.py | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/scripts/stubsabot.py b/scripts/stubsabot.py index 776330358cdc..7bcee21b5670 100644 --- a/scripts/stubsabot.py +++ b/scripts/stubsabot.py @@ -17,7 +17,7 @@ import urllib.parse import zipfile from collections.abc import Iterator, Mapping, Sequence -from dataclasses import dataclass +from dataclasses import dataclass, field from http import HTTPStatus from pathlib import Path from typing import Annotated, Any, ClassVar, NamedTuple @@ -105,8 +105,8 @@ def _best_effort_version(version: VersionString) -> packaging.version.Version: class PypiInfo: distribution: str pypi_root: str - releases: dict[VersionString, list[ReleaseDownload]] - info: dict[str, Any] + releases: dict[VersionString, list[ReleaseDownload]] = field(repr=False) + info: dict[str, Any] = field(repr=False) def get_release(self, *, version: VersionString) -> PypiReleaseDownload: # prefer wheels, since it's what most users will get / it's pretty easy to mess up MANIFEST @@ -143,7 +143,7 @@ class Update: old_version_spec: str new_version_spec: str links: dict[str, str] - diff_analysis: DiffAnalysis | None + diff_analysis: DiffAnalysis | None = field(repr=False) def __str__(self) -> str: return f"Updating {self.distribution} from {self.old_version_spec!r} to {self.new_version_spec!r}" @@ -244,7 +244,7 @@ def get_github_api_headers() -> Mapping[str, str]: @dataclass class GithubInfo: repo_path: str - tags: list[dict[str, Any]] + tags: list[dict[str, Any]] = field(repr=False) async def get_github_repo_info(session: aiohttp.ClientSession, stub_info: StubInfo) -> GithubInfo | None: @@ -323,12 +323,15 @@ def _plural_s(num: int, /) -> str: return "s" if num != 1 else "" -@dataclass +@dataclass(repr=False) class DiffAnalysis: MAXIMUM_NUMBER_OF_FILES_TO_LIST: ClassVar[int] = 7 py_files: list[FileInfo] py_files_stubbed_in_typeshed: list[FileInfo] + def __repr__(self) -> str: + return f"" + @property def runtime_definitely_has_consistent_directory_structure_with_typeshed(self) -> bool: """ From 0c03081c25e5e4a47cead3ebd660dd5c9d77182b Mon Sep 17 00:00:00 2001 From: AlexWaygood Date: Tue, 21 Nov 2023 14:06:45 +0000 Subject: [PATCH 2/3] Remove unnecessary change --- scripts/stubsabot.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/stubsabot.py b/scripts/stubsabot.py index 7bcee21b5670..d2795ee29c50 100644 --- a/scripts/stubsabot.py +++ b/scripts/stubsabot.py @@ -143,7 +143,7 @@ class Update: old_version_spec: str new_version_spec: str links: dict[str, str] - diff_analysis: DiffAnalysis | None = field(repr=False) + diff_analysis: DiffAnalysis | None def __str__(self) -> str: return f"Updating {self.distribution} from {self.old_version_spec!r} to {self.new_version_spec!r}" From b682d0dfc6f968de9ac50dcbdbb8d06c7edec2c0 Mon Sep 17 00:00:00 2001 From: Alex Waygood Date: Tue, 21 Nov 2023 14:18:42 +0000 Subject: [PATCH 3/3] don't need a custom repr for `DiffAnalysis` --- scripts/stubsabot.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/scripts/stubsabot.py b/scripts/stubsabot.py index d2795ee29c50..d5ea9d099df8 100644 --- a/scripts/stubsabot.py +++ b/scripts/stubsabot.py @@ -329,9 +329,6 @@ class DiffAnalysis: py_files: list[FileInfo] py_files_stubbed_in_typeshed: list[FileInfo] - def __repr__(self) -> str: - return f"" - @property def runtime_definitely_has_consistent_directory_structure_with_typeshed(self) -> bool: """