From 6b4411072781ffd4c5ea588a9661b893411db9b1 Mon Sep 17 00:00:00 2001 From: Avasam Date: Thu, 29 Feb 2024 15:50:49 -0500 Subject: [PATCH 1/2] Remove old type-ignore explanation comments not removed in #8280 --- stdlib/builtins.pyi | 1 - stdlib/importlib/metadata/__init__.pyi | 1 - stdlib/weakref.pyi | 1 - 3 files changed, 3 deletions(-) diff --git a/stdlib/builtins.pyi b/stdlib/builtins.pyi index 73e75dc34e6e..daba70a71245 100644 --- a/stdlib/builtins.pyi +++ b/stdlib/builtins.pyi @@ -98,7 +98,6 @@ class object: __annotations__: dict[str, Any] @property def __class__(self) -> type[Self]: ... - # Ignore errors about type mismatch between property getter and setter @__class__.setter def __class__(self, __type: type[object]) -> None: ... # noqa: F811 def __init__(self) -> None: ... diff --git a/stdlib/importlib/metadata/__init__.pyi b/stdlib/importlib/metadata/__init__.pyi index b2fe14777056..b41682b59f69 100644 --- a/stdlib/importlib/metadata/__init__.pyi +++ b/stdlib/importlib/metadata/__init__.pyi @@ -241,7 +241,6 @@ class MetadataPathFinder(DistributionFinder): @classmethod def find_distributions(cls, context: DistributionFinder.Context = ...) -> Iterable[PathDistribution]: ... if sys.version_info >= (3, 10): - # Yes, this is an instance method that has a parameter named "cls" def invalidate_caches(cls) -> None: ... class PathDistribution(Distribution): diff --git a/stdlib/weakref.pyi b/stdlib/weakref.pyi index 1bb2eacfb46a..5fc57602aa1a 100644 --- a/stdlib/weakref.pyi +++ b/stdlib/weakref.pyi @@ -93,7 +93,6 @@ class WeakValueDictionary(MutableMapping[_KT, _VT]): class KeyedRef(ref[_T], Generic[_KT, _T]): key: _KT - # This __new__ method uses a non-standard name for the "cls" parameter def __new__(type, ob: _T, callback: Callable[[_T], Any], key: _KT) -> Self: ... def __init__(self, ob: _T, callback: Callable[[_T], Any], key: _KT) -> None: ... From 50e1866edbe5c2ce974df46ccca8c66f094dc0de Mon Sep 17 00:00:00 2001 From: Avasam Date: Thu, 29 Feb 2024 16:12:43 -0500 Subject: [PATCH 2/2] Leave this one in --- stdlib/importlib/metadata/__init__.pyi | 1 + 1 file changed, 1 insertion(+) diff --git a/stdlib/importlib/metadata/__init__.pyi b/stdlib/importlib/metadata/__init__.pyi index b41682b59f69..b2fe14777056 100644 --- a/stdlib/importlib/metadata/__init__.pyi +++ b/stdlib/importlib/metadata/__init__.pyi @@ -241,6 +241,7 @@ class MetadataPathFinder(DistributionFinder): @classmethod def find_distributions(cls, context: DistributionFinder.Context = ...) -> Iterable[PathDistribution]: ... if sys.version_info >= (3, 10): + # Yes, this is an instance method that has a parameter named "cls" def invalidate_caches(cls) -> None: ... class PathDistribution(Distribution):