From 99bbe9c0f6b66c71301bdd77d145f301bb6afcaf Mon Sep 17 00:00:00 2001 From: Maxwell Muoto <41130755+max-muoto@users.noreply.github.com> Date: Sun, 2 Jun 2024 12:41:08 -0500 Subject: [PATCH 1/2] Add missing encoding arg --- stdlib/subprocess.pyi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/stdlib/subprocess.pyi b/stdlib/subprocess.pyi index 6234ecc02b48..c45f3c0ef525 100644 --- a/stdlib/subprocess.pyi +++ b/stdlib/subprocess.pyi @@ -1005,6 +1005,7 @@ if sys.version_info >= (3, 11): pass_fds: Collection[int] = ..., timeout: float | None = ..., *, + encoding: str | None = None, text: bool | None = None, user: str | int | None = None, group: str | int | None = None, @@ -1036,6 +1037,7 @@ elif sys.version_info >= (3, 10): pass_fds: Collection[int] = ..., timeout: float | None = ..., *, + encoding: str | None = None, text: bool | None = None, user: str | int | None = None, group: str | int | None = None, @@ -1066,6 +1068,7 @@ elif sys.version_info >= (3, 9): pass_fds: Collection[int] = ..., timeout: float | None = ..., *, + encoding: str | None = None, text: bool | None = None, user: str | int | None = None, group: str | int | None = None, @@ -1094,6 +1097,7 @@ else: pass_fds: Collection[int] = ..., timeout: float | None = ..., *, + encoding: str | None = None, text: bool | None = None, ) -> int: ... From d0d2bd4cb8962844a54b5f2be104ed9ffaa5d6da Mon Sep 17 00:00:00 2001 From: Maxwell Muoto <41130755+max-muoto@users.noreply.github.com> Date: Thu, 6 Jun 2024 10:37:37 -0400 Subject: [PATCH 2/2] Address comment --- stdlib/subprocess.pyi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/stdlib/subprocess.pyi b/stdlib/subprocess.pyi index c45f3c0ef525..b01bac2455ce 100644 --- a/stdlib/subprocess.pyi +++ b/stdlib/subprocess.pyi @@ -889,6 +889,7 @@ if sys.version_info >= (3, 11): start_new_session: bool = False, pass_fds: Collection[int] = ..., *, + encoding: str | None = None, timeout: float | None = None, text: bool | None = None, user: str | int | None = None, @@ -920,6 +921,7 @@ elif sys.version_info >= (3, 10): start_new_session: bool = False, pass_fds: Collection[int] = ..., *, + encoding: str | None = None, timeout: float | None = None, text: bool | None = None, user: str | int | None = None, @@ -950,6 +952,7 @@ elif sys.version_info >= (3, 9): start_new_session: bool = False, pass_fds: Collection[int] = ..., *, + encoding: str | None = None, timeout: float | None = None, text: bool | None = None, user: str | int | None = None, @@ -978,6 +981,7 @@ else: start_new_session: bool = False, pass_fds: Collection[int] = ..., *, + encoding: str | None = None, timeout: float | None = None, text: bool | None = None, ) -> int: ...