From a99f194fa3b85056694fa2047cf7bcceab277f58 Mon Sep 17 00:00:00 2001 From: donBarbos Date: Thu, 31 Jul 2025 16:00:11 +0400 Subject: [PATCH 1/4] [sqlite3] Deprecate `enable_shared_cache` from `dbapi2` I didn't look for source PR, but checked for `DeprecationWarning` at runtime. --- stdlib/sqlite3/dbapi2.pyi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/stdlib/sqlite3/dbapi2.pyi b/stdlib/sqlite3/dbapi2.pyi index d3ea3ef0e896..3482d817e2d9 100644 --- a/stdlib/sqlite3/dbapi2.pyi +++ b/stdlib/sqlite3/dbapi2.pyi @@ -66,6 +66,7 @@ from sqlite3 import ( Row as Row, Warning as Warning, ) +from typing_extensions import deprecated if sys.version_info >= (3, 12): from _sqlite3 import ( @@ -214,7 +215,7 @@ if sys.version_info < (3, 14): if sys.version_info < (3, 12): if sys.version_info >= (3, 10): - # deprecation wrapper that has a different name for the argument... + @deprecated("Deprecated since 3.10; removed in Python 3.12.") def enable_shared_cache(enable: int) -> None: ... else: from _sqlite3 import enable_shared_cache as enable_shared_cache From a4337a033ecfcc511d012cc7b84b9b2e6b597fd2 Mon Sep 17 00:00:00 2001 From: donBarbos Date: Fri, 1 Aug 2025 10:55:49 +0400 Subject: [PATCH 2/4] Update deprecation message --- stdlib/sqlite3/dbapi2.pyi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/stdlib/sqlite3/dbapi2.pyi b/stdlib/sqlite3/dbapi2.pyi index 1a82b388140b..2d244aa960fc 100644 --- a/stdlib/sqlite3/dbapi2.pyi +++ b/stdlib/sqlite3/dbapi2.pyi @@ -216,7 +216,9 @@ if sys.version_info < (3, 14): if sys.version_info < (3, 12): if sys.version_info >= (3, 10): - @deprecated("Deprecated since 3.10; removed in Python 3.12.") + @deprecated( + "Deprecated since 3.10; removed in Python 3.12. Instead, open database in URI mode using `cache=shared` parameter." + ) def enable_shared_cache(enable: int) -> None: ... else: from _sqlite3 import enable_shared_cache as enable_shared_cache From 6808f60933558d821d1c0819e6add4afb8bc3393 Mon Sep 17 00:00:00 2001 From: donBarbos Date: Fri, 1 Aug 2025 10:56:17 +0400 Subject: [PATCH 3/4] Back comment line --- stdlib/sqlite3/dbapi2.pyi | 1 + 1 file changed, 1 insertion(+) diff --git a/stdlib/sqlite3/dbapi2.pyi b/stdlib/sqlite3/dbapi2.pyi index 2d244aa960fc..c0253e796269 100644 --- a/stdlib/sqlite3/dbapi2.pyi +++ b/stdlib/sqlite3/dbapi2.pyi @@ -216,6 +216,7 @@ if sys.version_info < (3, 14): if sys.version_info < (3, 12): if sys.version_info >= (3, 10): + # deprecation wrapper that has a different name for the argument... @deprecated( "Deprecated since 3.10; removed in Python 3.12. Instead, open database in URI mode using `cache=shared` parameter." ) From bcad8c04ada4e54b6dbc833d4a9efccba93c7883 Mon Sep 17 00:00:00 2001 From: donBarbos Date: Thu, 21 Aug 2025 15:05:39 +0400 Subject: [PATCH 4/4] Update message --- stdlib/sqlite3/dbapi2.pyi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/stdlib/sqlite3/dbapi2.pyi b/stdlib/sqlite3/dbapi2.pyi index 00daf3b1bd9e..9e170a81243d 100644 --- a/stdlib/sqlite3/dbapi2.pyi +++ b/stdlib/sqlite3/dbapi2.pyi @@ -218,7 +218,8 @@ if sys.version_info < (3, 12): if sys.version_info >= (3, 10): # deprecation wrapper that has a different name for the argument... @deprecated( - "Deprecated since 3.10; removed in Python 3.12. Instead, open database in URI mode using `cache=shared` parameter." + "Deprecated since Python 3.10; removed in Python 3.12. " + "Open database in URI mode using `cache=shared` parameter instead." ) def enable_shared_cache(enable: int) -> None: ... else: