Using push constants for add mm native op. #16115
Merged
+23
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16115
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit d782674 with merge base 3ad2610 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@trivedivivek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88097601. |
trivedivivek
added
the
release notes: vulkan
yipjustin
approved these changes
Dec 5, 2025
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 8, 2025
Summary: The change replaces the shader params buffer with push constants in the add mm native op. This simplifies the shader and reduces the number of buffers used. Reviewed By: yipjustin Differential Revision: D88097601
trivedivivek
force-pushed
the
export-D88097601
branch
from
151b8cf to
096cbfd
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 8, 2025
Summary: The change replaces the shader params buffer with push constants in the add mm native op. This simplifies the shader and reduces the number of buffers used. Reviewed By: yipjustin Differential Revision: D88097601
trivedivivek
force-pushed
the
export-D88097601
branch
from
096cbfd to
e389c51
Compare
Summary: The change replaces the shader params buffer with push constants in the add mm native op. This simplifies the shader and reduces the number of buffers used. Reviewed By: yipjustin Differential Revision: D88097601
trivedivivek
force-pushed
the
export-D88097601
branch
from
e389c51 to
d782674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The change replaces the shader params buffer with push constants in the add mm native op. This simplifies the shader and reduces the number of buffers used.
Differential Revision: D88097601