From 72a820f27909a694aab71ae990b509a0f47e10c5 Mon Sep 17 00:00:00 2001 From: Scott Wolchok Date: Tue, 25 Feb 2025 10:15:41 -0800 Subject: [PATCH 1/2] Update [ghstack-poisoned] --- .ci/scripts/unittest-linux.sh | 18 +++++++++--------- .ci/scripts/unittest-macos.sh | 22 +++++++++++----------- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/.ci/scripts/unittest-linux.sh b/.ci/scripts/unittest-linux.sh index e76b43fa22c..5b83bfd044d 100755 --- a/.ci/scripts/unittest-linux.sh +++ b/.ci/scripts/unittest-linux.sh @@ -27,18 +27,18 @@ eval "$(conda shell.bash hook)" CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]") conda activate "${CONDA_ENV}" -# Setup swiftshader and Vulkan SDK which are required to build the Vulkan delegate -source .ci/scripts/setup-vulkan-linux-deps.sh +if [[ "$BUILD_TOOL" == "cmake" ]]; then + # Setup swiftshader and Vulkan SDK which are required to build the Vulkan delegate + source .ci/scripts/setup-vulkan-linux-deps.sh -PYTHON_EXECUTABLE=python \ -EXECUTORCH_BUILD_PYBIND=ON \ -CMAKE_ARGS="-DEXECUTORCH_BUILD_XNNPACK=ON -DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON" \ -.ci/scripts/setup-linux.sh "$BUILD_TOOL" "$BUILD_MODE" + PYTHON_EXECUTABLE=python \ + EXECUTORCH_BUILD_PYBIND=ON \ + CMAKE_ARGS="-DEXECUTORCH_BUILD_XNNPACK=ON -DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON" \ + .ci/scripts/setup-linux.sh "$BUILD_TOOL" "$BUILD_MODE" -# Install llama3_2_vision dependencies. -PYTHON_EXECUTABLE=python ./examples/models/llama3_2_vision/install_requirements.sh + # Install llama3_2_vision dependencies. + PYTHON_EXECUTABLE=python ./examples/models/llama3_2_vision/install_requirements.sh -if [[ "$BUILD_TOOL" == "cmake" ]]; then .ci/scripts/unittest-linux-cmake.sh elif [[ "$BUILD_TOOL" == "buck2" ]]; then .ci/scripts/unittest-buck2.sh diff --git a/.ci/scripts/unittest-macos.sh b/.ci/scripts/unittest-macos.sh index c0e39cee335..9f7fafa35ce 100755 --- a/.ci/scripts/unittest-macos.sh +++ b/.ci/scripts/unittest-macos.sh @@ -30,19 +30,19 @@ export TMP_DIR=$(mktemp -d) export PATH="${TMP_DIR}:$PATH" trap 'rm -rfv ${TMP_DIR}' EXIT -# Setup MacOS dependencies as there is no Docker support on MacOS atm -PYTHON_EXECUTABLE=python \ -EXECUTORCH_BUILD_PYBIND=ON \ -CMAKE_ARGS="-DEXECUTORCH_BUILD_COREML=ON -DEXECUTORCH_BUILD_MPS=ON -DEXECUTORCH_BUILD_XNNPACK=ON -DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON" \ -${CONDA_RUN} --no-capture-output \ -.ci/scripts/setup-macos.sh "${BUILD_TOOL}" "${BUILD_MODE}" +if [[ "$BUILD_TOOL" == "cmake" ]]; then + # Setup MacOS dependencies as there is no Docker support on MacOS atm + PYTHON_EXECUTABLE=python \ + EXECUTORCH_BUILD_PYBIND=ON \ + CMAKE_ARGS="-DEXECUTORCH_BUILD_COREML=ON -DEXECUTORCH_BUILD_MPS=ON -DEXECUTORCH_BUILD_XNNPACK=ON -DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON" \ + ${CONDA_RUN} --no-capture-output \ + .ci/scripts/setup-macos.sh "${BUILD_TOOL}" "${BUILD_MODE}" -# Install llama3_2_vision dependencies. -PYTHON_EXECUTABLE=python \ -${CONDA_RUN} --no-capture-output \ -./examples/models/llama3_2_vision/install_requirements.sh + # Install llama3_2_vision dependencies. + PYTHON_EXECUTABLE=python \ + ${CONDA_RUN} --no-capture-output \ + ./examples/models/llama3_2_vision/install_requirements.sh -if [[ "$BUILD_TOOL" == "cmake" ]]; then .ci/scripts/unittest-macos-cmake.sh elif [[ "$BUILD_TOOL" == "buck2" ]]; then .ci/scripts/unittest-buck2.sh From d85863cc03cff6279dfbfaa63e4f29012ba0379b Mon Sep 17 00:00:00 2001 From: Scott Wolchok Date: Tue, 25 Feb 2025 10:59:46 -0800 Subject: [PATCH 2/2] Update [ghstack-poisoned] --- .ci/scripts/unittest-linux.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.ci/scripts/unittest-linux.sh b/.ci/scripts/unittest-linux.sh index 5b83bfd044d..9b26b60e59f 100755 --- a/.ci/scripts/unittest-linux.sh +++ b/.ci/scripts/unittest-linux.sh @@ -41,6 +41,10 @@ if [[ "$BUILD_TOOL" == "cmake" ]]; then .ci/scripts/unittest-linux-cmake.sh elif [[ "$BUILD_TOOL" == "buck2" ]]; then + # XXX: check whether this is sufficient to unbreak sccache + PYTHON_EXECUTABLE=python \ + .ci/scripts/setup-linux.sh "$BUILD_TOOL" "$BUILD_MODE" + .ci/scripts/unittest-buck2.sh else echo "Unknown build tool $BUILD_TOOL"