From b47d94d639e9f91e6c16080548d83d58a02044f9 Mon Sep 17 00:00:00 2001 From: TheGupta2012 Date: Thu, 24 Apr 2025 10:56:18 +0530 Subject: [PATCH 1/2] add u1 to params map --- src/pyqasm/maps/gates.py | 2 ++ src/pyqasm/visitor.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/pyqasm/maps/gates.py b/src/pyqasm/maps/gates.py index 999c4828..f32a966d 100644 --- a/src/pyqasm/maps/gates.py +++ b/src/pyqasm/maps/gates.py @@ -1104,6 +1104,8 @@ def two_qubit_gate_op( "rz", "phaseshift", "p", + "u1", + "U1", "gpi", "gpi2", "xx", diff --git a/src/pyqasm/visitor.py b/src/pyqasm/visitor.py index 41fee124..d397002a 100644 --- a/src/pyqasm/visitor.py +++ b/src/pyqasm/visitor.py @@ -823,7 +823,7 @@ def _visit_basic_gate_operation( # pylint: disable=too-many-locals if len(op_parameters) != actual_num_params: raise_qasm3_error( - f"Expected {op_qubit_count} parameter{'s' if op_qubit_count > 1 else ''}" + f"Expected {actual_num_params} parameter{'s' if op_qubit_count == 1 else ''}" f" for gate '{operation.name.name}', but got {len(op_parameters)}", error_node=operation, span=operation.span, From 18ec9dabba14dae4bbb1ef53012a3bd8cc18ef1e Mon Sep 17 00:00:00 2001 From: TheGupta2012 Date: Thu, 24 Apr 2025 11:01:40 +0530 Subject: [PATCH 2/2] fix err msg and test --- src/pyqasm/visitor.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pyqasm/visitor.py b/src/pyqasm/visitor.py index d397002a..8435e901 100644 --- a/src/pyqasm/visitor.py +++ b/src/pyqasm/visitor.py @@ -823,7 +823,7 @@ def _visit_basic_gate_operation( # pylint: disable=too-many-locals if len(op_parameters) != actual_num_params: raise_qasm3_error( - f"Expected {actual_num_params} parameter{'s' if op_qubit_count == 1 else ''}" + f"Expected {actual_num_params} parameter{'s' if actual_num_params != 1 else ''}" f" for gate '{operation.name.name}', but got {len(op_parameters)}", error_node=operation, span=operation.span,