raiden: proxies: remove contract bytecode checking#7251
Merged
Conversation
4 tasks
Contributor
Author
|
This is not as urgent as it was before since we're not doing linking anymore, but if we're going to reuse the old secret registry on mainnet, which was compiled with a different version of solidity, then we may consider just removing the check. |
istankovic
force-pushed
the
contract-deployment
branch
from
14fb819 to
9fbd71a
Compare
ulope
approved these changes
Sep 17, 2021
Comment on lines
+1079
to
+1085
| def sync_nonce(self) -> None: | ||
| self._available_nonce = discover_next_available_nonce( | ||
| self.web3, self.eth_node, self.address | ||
| ) | ||
|
|
Collaborator
There was a problem hiding this comment.
AFAICS this is only used in the smoketest.
Therefore I'd either make it a private method or use a custom subclass with this method in the smoketest.
Contributor
|
Smoketests fail with: |
It's not all that useful and it prevents us from working with split contract code. See raiden-network#7203.
ContractDeployer supports linking, which our previous deployment mechanism based on JSONRPCClient does not.
fredo
force-pushed
the
contract-deployment
branch
from
9fbd71a to
5f6e3c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not all that useful and it prevents us from working
with split contract code.
See #7203.