Merge pull request #856 from p8/validate-option-arguments

Validate arguments for `method_option` and `class_option`

Author: rafaelfranca

lib/thor.rb

@@ -141,7 +141,7 @@ def method_options(options = nil)
     #     # magic
     #   end
     #
-    #   method_option :foo => :bar, :for => :previous_command
+    #   method_option :foo, :for => :previous_command
     #
     #   def next_command
     #     # magic
@@ -161,6 +161,9 @@ def method_options(options = nil)
     # :hide     - If you want to hide this option from the help.
     #
     def method_option(name, options = {})
+      unless [ Symbol, String ].any? { |klass| name.is_a?(klass) }
+        raise ArgumentError, "Expected a Symbol or String, got #{name.inspect}"
+      end
       scope = if options[:for]
         find_and_refresh_command(options[:for]).options
       else

lib/thor/base.rb

@@ -326,6 +326,9 @@ def class_options(options = nil)
       # :hide::     -- If you want to hide this option from the help.
       #
       def class_option(name, options = {})
+        unless [ Symbol, String ].any? { |klass| name.is_a?(klass) }
+          raise ArgumentError, "Expected a Symbol or String, got #{name.inspect}"
+        end
         build_option(name, options, class_options)
       end
 

spec/thor_spec.rb

@@ -750,6 +750,22 @@ def hi(name)
       expect(klass.start(%w(hi --loud jose))).to eq("Hi JOSE")
     end
 
+    it "method_option raises an ArgumentError if name is not a Symbol or String" do
+      expect do
+        Class.new(Thor) do
+          method_option loud: true, type: :boolean
+        end
+      end.to raise_error(ArgumentError, "Expected a Symbol or String, got {:loud=>true, :type=>:boolean}")
+    end
+
+    it "class_option raises an ArgumentError if name is not a Symbol or String" do
+      expect do
+        Class.new(Thor) do
+          class_option loud: true, type: :boolean
+        end
+      end.to raise_error(ArgumentError, "Expected a Symbol or String, got {:loud=>true, :type=>:boolean}")
+    end
+
     it "passes through unknown options" do
       klass = Class.new(Thor) do
         desc "unknown", "passing unknown options"