Fix inject into file warning #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
approved these changes
Jun 1, 2021
dorner
left a comment
dorner
left a comment
There was a problem hiding this comment.
This looks good - I'd like to see this merged in!
|
@nicolas-brousse can you rebase off master please? |
nicolas-brousse
force-pushed
the
fix-inject-into-file-warning
branch
from
4ae8925 to
bf3afab
Compare
nicolas-brousse
commented
Jun 3, 2021
lib/thor/actions/inject_into_file.rb
Outdated
Comment on lines
115
to
116
| before, after = content.split(regexp, 2) | ||
| snippet = (behavior == :after ? after : before).to_s |
Contributor
Author
There was a problem hiding this comment.
This code has been added. I've to found a way to deal this regexp.
Contributor
Author
|
For now when I tried locally, the test I added fail. I've to inspect how |
Member
|
Tests are broken |
rafaelfranca
force-pushed
the
fix-inject-into-file-warning
branch
from
bf3afab to
6499e07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if the fix implementation is good enough. Let me know if you want some changes.
Closes #706.