From d248e86bc27285427397e498b3f8e3edef7e2d45 Mon Sep 17 00:00:00 2001
From: harris-miller <harrismillerconsulting@gmail.com>
Date: Thu, 25 May 2023 02:50:37 -0600
Subject: [PATCH 1/5] better types for pluck

---
 types/pluck.d.ts | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/types/pluck.d.ts b/types/pluck.d.ts
index 934afa2e..6074edc9 100644
--- a/types/pluck.d.ts
+++ b/types/pluck.d.ts
@@ -1,4 +1,5 @@
-export function pluck<P extends string>(p: P): <T>(list: Array<Record<P, T>>) => T[];
-export function pluck(p: number): <T>(list: Array<{ [k: number]: T }>) => T[];
-export function pluck<K extends keyof T, T>(p: K, list: readonly T[]): Array<T[K]>;
-export function pluck<T>(p: number, list: Array<{ [k: number]: T }>): T[];
+import { Placeholder } from 'ramda';
+
+export function pluck<K extends PropertyKey>(prop: K extends Placeholder ? never : K): <U extends Record<K, any>>(list: U[]) => Array<U[K]>;
+export function pluck<U>(__: Placeholder, list: U[]): <K extends keyof U>() => Array<U[K]>;
+export function pluck<K extends keyof U, U>(p: K, list: readonly U[]): Array<U[K]>;

From 51b287c4bd473e95d4b491eef6ebaba4bf2e639c Mon Sep 17 00:00:00 2001
From: harris-miller <harrismillerconsulting@gmail.com>
Date: Thu, 25 May 2023 03:26:03 -0600
Subject: [PATCH 2/5] that's better

---
 types/pluck.d.ts | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/types/pluck.d.ts b/types/pluck.d.ts
index 6074edc9..91023fec 100644
--- a/types/pluck.d.ts
+++ b/types/pluck.d.ts
@@ -1,5 +1,7 @@
 import { Placeholder } from 'ramda';
 
-export function pluck<K extends PropertyKey>(prop: K extends Placeholder ? never : K): <U extends Record<K, any>>(list: U[]) => Array<U[K]>;
-export function pluck<U>(__: Placeholder, list: U[]): <K extends keyof U>() => Array<U[K]>;
-export function pluck<K extends keyof U, U>(p: K, list: readonly U[]): Array<U[K]>;
+export function pluck<K extends PropertyKey>(prop: K extends Placeholder ? never : K): {
+  <U extends unknown[] | Record<K, any>>(list: U[]): U extends (infer T)[] ? T[] : U extends Record<K, infer T> ? T[] : never;
+};
+export function pluck<U>(__: Placeholder, list: readonly U[]): <K extends keyof U>(prop: K) => Array<U[K]>;
+export function pluck<K extends keyof U, U>(prop: K, list: readonly U[]): Array<U[K]>;

From 2f527b9813dd3c6d94e6ed823d8c77e3ae03e37d Mon Sep 17 00:00:00 2001
From: harris-miller <harrismillerconsulting@gmail.com>
Date: Thu, 25 May 2023 03:29:24 -0600
Subject: [PATCH 3/5] don't forget the readonlys

---
 types/pluck.d.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/types/pluck.d.ts b/types/pluck.d.ts
index 91023fec..5104eb07 100644
--- a/types/pluck.d.ts
+++ b/types/pluck.d.ts
@@ -1,7 +1,7 @@
 import { Placeholder } from 'ramda';
 
 export function pluck<K extends PropertyKey>(prop: K extends Placeholder ? never : K): {
-  <U extends unknown[] | Record<K, any>>(list: U[]): U extends (infer T)[] ? T[] : U extends Record<K, infer T> ? T[] : never;
+  <U extends readonly unknown[] | Record<K, any>>(list: U[]): U extends readonly (infer T)[] ? T[] : U extends Record<K, infer T> ? T[] : never;
 };
 export function pluck<U>(__: Placeholder, list: readonly U[]): <K extends keyof U>(prop: K) => Array<U[K]>;
 export function pluck<K extends keyof U, U>(prop: K, list: readonly U[]): Array<U[K]>;

From cc7ae0ade2e703d70e3d01b971e73ac04f7c362c Mon Sep 17 00:00:00 2001
From: harris-miller <harrismillerconsulting@gmail.com>
Date: Thu, 25 May 2023 03:32:30 -0600
Subject: [PATCH 4/5] support objects

---
 types/pluck.d.ts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/types/pluck.d.ts b/types/pluck.d.ts
index 5104eb07..5db36472 100644
--- a/types/pluck.d.ts
+++ b/types/pluck.d.ts
@@ -1,7 +1,10 @@
 import { Placeholder } from 'ramda';
 
 export function pluck<K extends PropertyKey>(prop: K extends Placeholder ? never : K): {
+  <U extends readonly unknown[] | Record<K, any>>(obj: Record<PropertyKey, U>): U extends readonly (infer T)[] ? T[] : U extends Record<K, infer T> ? T[] : never;
   <U extends readonly unknown[] | Record<K, any>>(list: U[]): U extends readonly (infer T)[] ? T[] : U extends Record<K, infer T> ? T[] : never;
 };
+export function pluck<U>(__: Placeholder, obj: Record<PropertyKey, U>): <K extends keyof U>(prop: K) => Array<U[K]>;
 export function pluck<U>(__: Placeholder, list: readonly U[]): <K extends keyof U>(prop: K) => Array<U[K]>;
+export function pluck<K extends keyof U, U>(prop: K, obj: Record<PropertyKey, U>): Array<U[K]>;
 export function pluck<K extends keyof U, U>(prop: K, list: readonly U[]): Array<U[K]>;

From a7a8b3c969902c44e5ba6b406441a33fde61293d Mon Sep 17 00:00:00 2001
From: harris-miller <harrismillerconsulting@gmail.com>
Date: Mon, 2 Oct 2023 00:42:57 -0600
Subject: [PATCH 5/5] pluck tests

---
 test/pluck.test.ts | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 test/pluck.test.ts

diff --git a/test/pluck.test.ts b/test/pluck.test.ts
new file mode 100644
index 00000000..5575b24d
--- /dev/null
+++ b/test/pluck.test.ts
@@ -0,0 +1,35 @@
+import { expectType, expectError } from 'tsd';
+
+import { __, pluck } from '../es';
+
+type Obj = { name: string; age: number };
+
+// pluck(key, list)
+expectType<string[]>(pluck('name', [] as Obj[]));
+expectType<number[]>(pluck('age', [] as Obj[]));
+expectError(pluck('nope', [] as Obj[]));
+
+// pluck(key)(list)
+expectType<string[]>(pluck('name')([] as Obj[]));
+expectType<number[]>(pluck('age')([] as Obj[]));
+expectError(pluck('nope')([] as Obj[]));
+
+// pluck(__, list)(prop)
+expectType<string[]>(pluck(__, [] as Obj[])('name'));
+expectType<number[]>(pluck(__, [] as Obj[])('age'));
+expectError(pluck(__, [] as Obj[])('nope'));
+
+// pluck(key, record)
+expectType<string[]>(pluck('name', {} as Record<string, Obj>));
+expectType<number[]>(pluck('age', {} as Record<string, Obj>));
+expectError(pluck('nope', {} as Record<string, Obj>));
+
+// pluck(key)(record)
+expectType<string[]>(pluck('name')({} as Record<string, Obj>));
+expectType<number[]>(pluck('age')({} as Record<string, Obj>));
+expectError(pluck('nope')({} as Record<string, Obj>));
+
+// pluck(__, record)(prop)
+expectType<string[]>(pluck(__, {} as Record<string, Obj>)('name'));
+expectType<number[]>(pluck(__, {} as Record<string, Obj>)('age'));
+expectError(pluck(__, {} as Record<string, Obj>)('nope'));