From 4a0dbc6a878b7adabdfee18af9ab3e6f76b4849a Mon Sep 17 00:00:00 2001 From: Matthew Kienow Date: Mon, 31 Jan 2022 17:54:55 -0500 Subject: [PATCH 1/2] Report untested parameter as a failure --- recog/src/main/java/com/rapid7/recog/RecogMatcher.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/recog/src/main/java/com/rapid7/recog/RecogMatcher.java b/recog/src/main/java/com/rapid7/recog/RecogMatcher.java index 48c6286..db532aa 100644 --- a/recog/src/main/java/com/rapid7/recog/RecogMatcher.java +++ b/recog/src/main/java/com/rapid7/recog/RecogMatcher.java @@ -287,7 +287,7 @@ private void verifyExamplesHaveCaptureGroups(BiConsumer co Boolean paramUsed = entry.getValue(); if (!paramUsed) { String message = String.format("'%s' is missing an example that checks for parameter '%s' which is derived from a capture group", description, paramName); - consumer.accept(VerifyStatus.Warn, message); + consumer.accept(VerifyStatus.Fail, message); } } } From 412adc4b4acd9b4bf4e0406e5716906eebbdf818 Mon Sep 17 00:00:00 2001 From: Matthew Kienow Date: Mon, 31 Jan 2022 17:59:25 -0500 Subject: [PATCH 2/2] Modify test for example with an untested parameter --- .../rapid7/recog/verify/RecogVerifierTest.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/recog-verify/src/test/java/com/rapid7/recog/verify/RecogVerifierTest.java b/recog-verify/src/test/java/com/rapid7/recog/verify/RecogVerifierTest.java index 767f443..3b1baa6 100644 --- a/recog-verify/src/test/java/com/rapid7/recog/verify/RecogVerifierTest.java +++ b/recog-verify/src/test/java/com/rapid7/recog/verify/RecogVerifierTest.java @@ -87,13 +87,13 @@ public void verifyNoExampleNonZeroPositionParamsWarnCount() throws ParseExceptio } @Test - public void verifySuccessfulExampleNonZeroPositionParamsWarnCount() throws ParseException { + public void verifySuccessfulExample() throws ParseException { // given String xml = "\n" + "\n" + " \n" + " Service Server - no examples or params\n" - + " Media Server 7.9.3 - 1631723269\n" + + " Media Server 7.9.3 - 1631723269\n" + " \n" + " \n" + " \n" @@ -112,16 +112,17 @@ public void verifySuccessfulExampleNonZeroPositionParamsWarnCount() throws Parse // then assertEquals(1, verifier.getReporter().getSuccessCount()); assertEquals(0, verifier.getReporter().getFailureCount()); - assertEquals(3, verifier.getReporter().getWarningCount()); + assertEquals(0, verifier.getReporter().getWarningCount()); } @Test - public void verifySuccessfulExample() throws ParseException { + public void verify1FailureAnd1SuccessfulExamples() throws ParseException { // given String xml = "\n" + "\n" + " \n" + " Service Server - no examples or params\n" + + " Media Server 1.2.3.4\n" + " Media Server 7.9.3 - 1631723269\n" + " \n" + " \n" @@ -140,19 +141,18 @@ public void verifySuccessfulExample() throws ParseException { // then assertEquals(1, verifier.getReporter().getSuccessCount()); - assertEquals(0, verifier.getReporter().getFailureCount()); + assertEquals(1, verifier.getReporter().getFailureCount()); assertEquals(0, verifier.getReporter().getWarningCount()); } @Test - public void verify1FailureAnd1SuccessfulExamples() throws ParseException { + public void verifySuccessfulExampleUntestedParamsFailCount() throws ParseException { // given String xml = "\n" + "\n" + " \n" + " Service Server - no examples or params\n" - + " Media Server 1.2.3.4\n" - + " Media Server 7.9.3 - 1631723269\n" + + " Media Server 7.9.3 - 1631723269\n" + " \n" + " \n" + " \n" @@ -170,7 +170,7 @@ public void verify1FailureAnd1SuccessfulExamples() throws ParseException { // then assertEquals(1, verifier.getReporter().getSuccessCount()); - assertEquals(1, verifier.getReporter().getFailureCount()); + assertEquals(3, verifier.getReporter().getFailureCount()); assertEquals(0, verifier.getReporter().getWarningCount()); }