Draft
Conversation
Owner
Author
|
Gallery test timings:
Which suggests the extra time to run the examples multiple times is within the CI variability. |
Owner
Author
|
Treating the GloSea example the same as all the others, the gallery tests took 68.34 seconds or 67.36 seconds (ran twice to get an idea of variability). Seems to be a significant increase, so it's probably worth having the special handling for the GloSea example. |
rcomer
force-pushed
the
gallerytest-one-test-per-fig
branch
from
4461cf4 to
c7ad34d
Compare
rcomer
force-pushed
the
pytest-gallerytest
branch
from
f782d73 to
feddd39
Compare
rcomer
force-pushed
the
gallerytest-one-test-per-fig
branch
from
c7ad34d to
bb685fd
Compare
rcomer
force-pushed
the
pytest-gallerytest
branch
2 times, most recently
from
ca43e78 to
48824b4
Compare
rcomer
force-pushed
the
gallerytest-one-test-per-fig
branch
from
bb685fd to
22348cb
Compare
rcomer
force-pushed
the
pytest-gallerytest
branch
2 times, most recently
from
b39aaaf to
b0eb077
Compare
class for GloSea example to reduce runtime this class addition brings total run time of gallery tests from ~3:40 to ~2:35 (total time before this branch ~2:20). Timings on ancient laptop. tidyings
This reverts commit 814251d.
rcomer
force-pushed
the
gallerytest-one-test-per-fig
branch
from
22348cb to
c7b3ab0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
If/when we adopt
pytest-mplwe will need to return a single figure from each test.https://github.com/matplotlib/pytest-mpl
Since some of the gallery examples produce more than one figure, we need a way to split them up. The simplest option is to run the whole example for each of our N tests, but have each test select a different figure to return. That would be less efficient than the current situation, but how much that matters depends on how lightweight the relevant examples are.
The GloSea "lagged ensemble" example is particularly slow, probably because it loads multiple pp-fields. So this branch implements a class that runs that code once to provide the two figures for the two tests. All other examples run the code once per test, as above.
Note this branch still uses the
iris.tests.check_graphicfunction rather thanpytest-mpl.Consult Iris pull request check list