From 57bfebf5c1d5da8d09218ffe1dac007ce3ec2874 Mon Sep 17 00:00:00 2001 From: Bentaimia Haddadi Date: Mon, 8 Jul 2019 17:36:00 +0200 Subject: [PATCH 1/2] fix: fix project directory name in run instructions --- packages/cli/src/commands/init/printRunInstructions.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/src/commands/init/printRunInstructions.js b/packages/cli/src/commands/init/printRunInstructions.js index 43258c85a..543387d1a 100644 --- a/packages/cli/src/commands/init/printRunInstructions.js +++ b/packages/cli/src/commands/init/printRunInstructions.js @@ -14,7 +14,7 @@ import chalk from 'chalk'; import {logger} from '@react-native-community/cli-tools'; function printRunInstructions(projectDir: string, projectName: string) { - const absoluteProjectDir = path.resolve(projectDir); + const absoluteProjectDir = path.resolve(`${projectDir}/${projectName}`); const iosProjectDir = path.resolve(projectDir, 'ios'); const iosPodsFile = path.resolve(iosProjectDir, `${projectName}.xcworkspace`); From b0704bba6da4144c3ec7c3ca5f9333c1212813ee Mon Sep 17 00:00:00 2001 From: Bentaimia Haddadi Date: Tue, 9 Jul 2019 09:24:51 +0200 Subject: [PATCH 2/2] fix: pass the right project directory to printRunInstructions --- packages/cli/src/commands/init/init.js | 3 ++- packages/cli/src/commands/init/printRunInstructions.js | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/cli/src/commands/init/init.js b/packages/cli/src/commands/init/init.js index 61bcd1c83..b55557fe8 100644 --- a/packages/cli/src/commands/init/init.js +++ b/packages/cli/src/commands/init/init.js @@ -218,7 +218,8 @@ export default (async function initialize( try { await createProject(projectName, directoryName, version, options); - printRunInstructions(rootFolder, projectName); + const projectFolder = path.join(rootFolder, projectName); + printRunInstructions(projectFolder, projectName); } catch (e) { logger.error(e.message); // Only remove project if it didn't exist before running `init` diff --git a/packages/cli/src/commands/init/printRunInstructions.js b/packages/cli/src/commands/init/printRunInstructions.js index 543387d1a..43258c85a 100644 --- a/packages/cli/src/commands/init/printRunInstructions.js +++ b/packages/cli/src/commands/init/printRunInstructions.js @@ -14,7 +14,7 @@ import chalk from 'chalk'; import {logger} from '@react-native-community/cli-tools'; function printRunInstructions(projectDir: string, projectName: string) { - const absoluteProjectDir = path.resolve(`${projectDir}/${projectName}`); + const absoluteProjectDir = path.resolve(projectDir); const iosProjectDir = path.resolve(projectDir, 'ios'); const iosPodsFile = path.resolve(iosProjectDir, `${projectName}.xcworkspace`);