Skip to content

Commit bb10955

Browse files
Prevent ShareIntentTextRenderer from escaping chars from HTML
1 parent 64f3173 commit bb10955

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

app/src/androidTest/java/com/readrops/app/TemplateTest.kt

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ package com.readrops.app
22

33
import com.readrops.app.util.FrenchTypography
44
import com.readrops.app.util.RemoveAuthorFilter
5+
import com.readrops.app.util.ShareIntentTextRenderer
6+
import com.readrops.db.entities.Item
57
import kotlinx.coroutines.test.runTest
68
import org.junit.Test
79
import kotlin.test.assertEquals
@@ -32,4 +34,11 @@ class TemplateTest {
3234
assertEquals(" :", FrenchTypography.filter(" :"))
3335
assertEquals(" ;", FrenchTypography.filter(" ;"))
3436
}
35-
}
37+
38+
/** Asserts rendered won't HTML escape */
39+
@Test
40+
fun dontEscape() {
41+
val renderer = ShareIntentTextRenderer(Item(title = "\"Title\""))
42+
assertEquals("\"Title\"", renderer.render("{{ title }}"))
43+
}
44+
}

app/src/main/java/com/readrops/app/util/ShareIntentTextRenderer.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ class ShareIntentTextRenderer(private val item: Item): KoinComponent {
126126
override fun getFilters(): Map<String, Filter> = this@Companion.filters
127127
})
128128
.newLineTrimming(false)
129+
.autoEscaping(false)
129130
.build()
130131
}
131-
}
132+
}

0 commit comments

Comments
 (0)