From 057e68858b3125b52c156607928c01f959905751 Mon Sep 17 00:00:00 2001 From: Javier Chavarri Date: Thu, 24 Aug 2023 08:47:00 +0000 Subject: [PATCH 1/3] add npm depexts --- reason-react.opam | 4 ++++ reason-react.opam.template | 4 ++++ 2 files changed, 8 insertions(+) create mode 100644 reason-react.opam.template diff --git a/reason-react.opam b/reason-react.opam index b8356ba73..b90d4ae0b 100644 --- a/reason-react.opam +++ b/reason-react.opam @@ -40,3 +40,7 @@ build: [ ] ] dev-repo: "git+https://github.com/reasonml/reason-react.git" +depexts: [ + ["react"] {npm-version = "^16.0.0"} + ["react-dom"] {npm-version = "^16.0.0"} +] diff --git a/reason-react.opam.template b/reason-react.opam.template new file mode 100644 index 000000000..d19261ae8 --- /dev/null +++ b/reason-react.opam.template @@ -0,0 +1,4 @@ +depexts: [ + ["react"] {npm-version = "^16.0.0"} + ["react-dom"] {npm-version = "^16.0.0"} +] From 072960b60e592459ad7a78c6d8c92d998d32fd8d Mon Sep 17 00:00:00 2001 From: Javier Chavarri Date: Thu, 24 Aug 2023 08:55:30 +0000 Subject: [PATCH 2/3] add opam-check-npm-deps to deps --- dune-project | 4 +++- reason-react.opam | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/dune-project b/dune-project index fa180f87f..40cf7f7cb 100644 --- a/dune-project +++ b/dune-project @@ -40,7 +40,9 @@ reason-react-ppx (reason (>= 3.6.0)) - (ocaml-lsp-server :with-test))) + (ocaml-lsp-server :with-test) + (opam-check-npm-deps + (= 1.0.0 :with-dev-setup)))) (package (name reason-react-ppx) diff --git a/reason-react.opam b/reason-react.opam index b90d4ae0b..1eda446b8 100644 --- a/reason-react.opam +++ b/reason-react.opam @@ -23,6 +23,7 @@ depends: [ "reason-react-ppx" "reason" {>= "3.6.0"} "ocaml-lsp-server" {with-test} + "opam-check-npm-deps" {"1.0.0" = with-dev-setup} "odoc" {with-doc} ] build: [ From fed8aab12e51e5647040e63020ce4354ccb78c89 Mon Sep 17 00:00:00 2001 From: Javier Chavarri Date: Thu, 24 Aug 2023 09:17:52 +0000 Subject: [PATCH 3/3] remove peerDeps --- package.json | 4 ---- 1 file changed, 4 deletions(-) diff --git a/package.json b/package.json index 1767cfa4a..1534d62f0 100644 --- a/package.json +++ b/package.json @@ -30,10 +30,6 @@ "react-dom": "^16.8.1", "react-test-renderer": "^16.13.1" }, - "peerDependencies": { - "react": "^16.8.1", - "react-dom": "^16.8.1" - }, "jest": { "moduleDirectories": [ "node_modules"