fix(rime_api.cc): using unchecked fields introduced an ABI breakage

lotem · lotem · commit 62bbeada3d4f · 2019-12-23T13:55:00.000+08:00
#328 (review)
diff --git a/src/rime_api.cc b/src/rime_api.cc
@@ -68,7 +68,11 @@ RIME_API void RimeSetup(RimeTraits *traits) {
 
   setup_deployer(traits);
   if (PROVIDED(traits, app_name)) {
-    SetupLogging(traits->app_name, traits->min_log_level, traits->log_dir);
+    if (PROVIDED(traits, min_log_level) && PROVIDED(traits, log_dir)) {
+      SetupLogging(traits->app_name, traits->min_log_level, traits->log_dir);
+    } else {
+      SetupLogging(traits->app_name);
+    }
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,11 @@ RIME_API void RimeSetup(RimeTraits *traits) {`
`68`	`68`
`69`	`69`	`setup_deployer(traits);`
`70`	`70`	`if (PROVIDED(traits, app_name)) {`
`71`		`- SetupLogging(traits->app_name, traits->min_log_level, traits->log_dir);`
	`71`	`+ if (PROVIDED(traits, min_log_level) && PROVIDED(traits, log_dir)) {`
	`72`	`+ SetupLogging(traits->app_name, traits->min_log_level, traits->log_dir);`
	`73`	`+ } else {`
	`74`	`+ SetupLogging(traits->app_name);`
	`75`	`+ }`
`72`	`76`	`}`
`73`	`77`	`}`
`74`	`78`