From 326ec87334a423c7fe286a24e74f89d3fe0a178a Mon Sep 17 00:00:00 2001 From: Blake Gentry Date: Fri, 17 Nov 2023 20:25:11 -0600 Subject: [PATCH] effectively disable reindexer At this time, we're not sure we want to have a reindexer process automatically running. It could be a net negative for many use cases and we may want to do further work to avoid its potential downsides. For now, disable it by simply removing all the indexes from its default index list. --- client_test.go | 1 + internal/maintenance/reindexer.go | 5 +---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/client_test.go b/client_test.go index a38157be..3f20e3cf 100644 --- a/client_test.go +++ b/client_test.go @@ -1310,6 +1310,7 @@ func Test_Client_Maintenance(t *testing.T) { t.Run("Reindexer", func(t *testing.T) { t.Parallel() + t.Skip("Reindexer is disabled for further development") config := newTestConfig(t, nil) config.ReindexerSchedule = cron.Every(time.Second) diff --git a/internal/maintenance/reindexer.go b/internal/maintenance/reindexer.go index 54f43e1e..02e11b23 100644 --- a/internal/maintenance/reindexer.go +++ b/internal/maintenance/reindexer.go @@ -19,7 +19,7 @@ const ( DefaultTimeout = 15 * time.Second ) -var defaultIndexNames = []string{"river_job_metadata_index", "river_job_args_index"} //nolint:gochecknoglobals +var defaultIndexNames = []string{} //nolint:gochecknoglobals // Test-only properties. type ReindexerTestSignals struct { @@ -43,9 +43,6 @@ type ReindexerConfig struct { } func (c *ReindexerConfig) mustValidate() *ReindexerConfig { - if len(c.IndexNames) < 1 { - panic("ReindexerConfig.IndexNames must have at least one entry") - } if c.ScheduleFunc == nil { panic("ReindexerConfig.ScheduleFunc must be set") }