Skip to content

Commit 973ff54

Browse files
committed
Clean up rake file and use correct extension on Windows.
1 parent 6ac0e2f commit 973ff54

File tree

2 files changed

+1
-27
lines changed

2 files changed

+1
-27
lines changed

Rakefile

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,13 @@
22

33
require "bundler/gem_tasks"
44
require "rake/testtask"
5-
require "rake/extensiontask"
65
require "rubygems/package_task"
76

87
GEM_NAME = 'bitmap-plus-plus'
98
SO_NAME = 'bitmap_plus_plus'
109

1110
gemspec = Gem::Specification.load("#{GEM_NAME}.gemspec")
1211

13-
# Extension task for compiling the C++ extension
14-
Rake::ExtensionTask.new("bitmap_plus_plus") do |ext|
15-
ext.lib_dir = "lib"
16-
end
17-
1812
# Rake task to build the default package
1913
Gem::PackageTask.new(gemspec) do |pkg|
2014
pkg.need_tar = true
@@ -28,23 +22,3 @@ Rake::TestTask.new(:test) do |t|
2822
t.verbose = true
2923
t.warning = true
3024
end
31-
32-
# # Make sure extension is compiled before running tests
33-
# task test: :compile
34-
#
35-
# # Default task
36-
# task default: %i[compile test]
37-
#
38-
# # Clean task
39-
# CLEAN.include("lib/*.so", "lib/*.dll", "lib/*.bundle")
40-
# CLEAN.include("tmp")
41-
#
42-
# desc "Build the gem"
43-
# task :gem do
44-
# sh "gem build bitmap-plus-plus.gemspec"
45-
# end
46-
#
47-
# desc "Install the gem locally"
48-
# task install: :gem do
49-
# sh "gem install bitmap-plus-plus-*.gem"
50-
# end

ext/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ target_include_directories(${CMAKE_PROJECT_NAME} PRIVATE .)
3838
get_target_property(RUBY_EXT_SUFFIX Ruby::Ruby INTERFACE_RUBY_EXTENSION_SUFFIX)
3939
set_target_properties(${CMAKE_PROJECT_NAME} PROPERTIES
4040
PREFIX ""
41-
#SUFFIX "${RUBY_EXT_SUFFIX}"
41+
SUFFIX "${RUBY_EXT_SUFFIX}"
4242
OUTPUT_NAME "bitmap_plus_plus_ruby"
4343
CXX_VISIBILITY_PRESET hidden
4444
VISIBILITY_INLINES_HIDDEN ON

0 commit comments

Comments
 (0)