From 2e61c8c66c18a2d12633a599febc46b56464c982 Mon Sep 17 00:00:00 2001
From: Jeremy Evans <code@jeremyevans.net>
Date: Thu, 15 Aug 2019 15:21:55 -0700
Subject: [PATCH 1/2] Make def_{instance,single}_delegators skip :__send__ and
 :__id__

Previously, __send__ and __id__ were skipped if provided as strings,
but not skipped if provided as symbols.

Fixes Ruby Bug 8855.
---
 lib/forwardable.rb       | 10 ++++------
 test/test_forwardable.rb | 24 ++++++++++++++++++++++++
 2 files changed, 28 insertions(+), 6 deletions(-)

diff --git a/lib/forwardable.rb b/lib/forwardable.rb
index 449c344..7ef93e9 100644
--- a/lib/forwardable.rb
+++ b/lib/forwardable.rb
@@ -148,9 +148,8 @@ def instance_delegate(hash)
   #   def_delegator :@records, :map
   #
   def def_instance_delegators(accessor, *methods)
-    methods.delete("__send__")
-    methods.delete("__id__")
-    for method in methods
+    methods.each do |method|
+      next if method.to_s == "__send__" || method.to_s == "__id__"
       def_instance_delegator(accessor, method)
     end
   end
@@ -280,9 +279,8 @@ def single_delegate(hash)
   #   def_delegator :@records, :map
   #
   def def_single_delegators(accessor, *methods)
-    methods.delete("__send__")
-    methods.delete("__id__")
-    for method in methods
+    methods.each do |method|
+      next if method.to_s == "__send__" || method.to_s == "__id__"
       def_single_delegator(accessor, method)
     end
   end
diff --git a/test/test_forwardable.rb b/test/test_forwardable.rb
index b3f8467..9101eff 100644
--- a/test/test_forwardable.rb
+++ b/test/test_forwardable.rb
@@ -96,6 +96,18 @@ def test_def_instance_delegators_using_block_method_as_receiver
     end
   end
 
+  def test_def_instance_delegators_send_id
+    %i[def_delegators def_instance_delegators].each do |m|
+      cls = forwardable_class do
+        attr_reader :receiver
+        __send__ m, :@receiver, :__send__, :__id__
+      end
+
+      assert_not_equal cls.new.__id__, cls.new.receiver.__id__
+      assert_not_equal cls.new.__send__(:__id__), cls.new.receiver.__send__(:__id__)
+    end
+  end
+
   def test_instance_delegate
     %i[delegate instance_delegate].each do |m|
       cls = forwardable_class do
@@ -204,6 +216,18 @@ def test_obj_single_delegators
     end
   end
 
+  def test_obj_single_delegators_send_id
+    %i[def_delegators def_single_delegators].each do |m|
+      obj = single_forwardable_object do
+        singleton_class.attr_reader :receiver
+        __send__ m, :@receiver, :__send__, :__id__
+      end
+
+      assert_not_equal obj.__id__, obj.receiver.__id__
+      assert_not_equal obj.__send__(:__id__), obj.receiver.__send__(:__id__)
+    end
+  end
+
   def test_obj_single_delegate
     %i[delegate single_delegate].each do |m|
       obj = single_forwardable_object do

From 1a994c90e1fa4d2d8e603363c8ffb3a922b4c59e Mon Sep 17 00:00:00 2001
From: Jeremy Evans <code@jeremyevans.net>
Date: Wed, 21 Aug 2019 07:33:28 -0700
Subject: [PATCH 2/2] Remove string allocation in
 def_{instance,single}_delegators

---
 lib/forwardable.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/forwardable.rb b/lib/forwardable.rb
index 7ef93e9..ee0038d 100644
--- a/lib/forwardable.rb
+++ b/lib/forwardable.rb
@@ -149,7 +149,7 @@ def instance_delegate(hash)
   #
   def def_instance_delegators(accessor, *methods)
     methods.each do |method|
-      next if method.to_s == "__send__" || method.to_s == "__id__"
+      next if /\A__(?:send|id)__\z/ =~ method
       def_instance_delegator(accessor, method)
     end
   end
@@ -280,7 +280,7 @@ def single_delegate(hash)
   #
   def def_single_delegators(accessor, *methods)
     methods.each do |method|
-      next if method.to_s == "__send__" || method.to_s == "__id__"
+      next if /\A__(?:send|id)__\z/ =~ method
       def_single_delegator(accessor, method)
     end
   end