From 3ee010b5383735d6068ec4fd8e7946d18d856a78 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Thu, 18 Nov 2021 21:45:04 +0100 Subject: [PATCH] Officially drop support for ruby 2.6 or older The gem doesn't even install on old rubies, but since the gemspec claims it's supported, `gem install pathname` will try to install it and print an error. This commit doesn't fix the above issue. The only way to fix it would be to restore support and release a new version that actually supports old rubies. However, such a change has been proposed and ignored for a long time. So this issue proposes to leave that broken but at least bring the gemspec manifest and the CI matrix in sync to hopefully avoid this issue from happening again in the future. --- .github/workflows/test.yml | 2 +- pathname.gemspec | 2 +- test/lib/core_assertions.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 5bcd688..ac51672 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -7,7 +7,7 @@ jobs: name: build (${{ matrix.ruby }} / ${{ matrix.os }}) strategy: matrix: - ruby: [ '3.0', head ] + ruby: [ 2.7, '3.0', head ] os: [ ubuntu-latest, macos-latest, windows-latest ] exclude: - { os: windows-latest , ruby: head } diff --git a/pathname.gemspec b/pathname.gemspec index 5aaa8f8..c9c0b84 100644 --- a/pathname.gemspec +++ b/pathname.gemspec @@ -7,7 +7,7 @@ Gem::Specification.new do |spec| spec.summary = %q{Representation of the name of a file or directory on the filesystem} spec.description = %q{Representation of the name of a file or directory on the filesystem} spec.homepage = "https://github.com/ruby/pathname" - spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0") + spec.required_ruby_version = Gem::Requirement.new(">= 2.7.0") spec.licenses = ["Ruby", "BSD-2-Clause"] spec.metadata["homepage_uri"] = spec.homepage diff --git a/test/lib/core_assertions.rb b/test/lib/core_assertions.rb index 4471525..720883a 100644 --- a/test/lib/core_assertions.rb +++ b/test/lib/core_assertions.rb @@ -695,7 +695,7 @@ def assert_join_threads(threads, message = nil) msg = "exceptions on #{errs.length} threads:\n" + errs.map {|t, err| "#{t.inspect}:\n" + - RUBY_VERSION >= "2.5.0" ? err.full_message(highlight: false, order: :top) : err.message + err.full_message(highlight: false, order: :top) }.join("\n---\n") if message msg = "#{message}\n#{msg}"