From 78df8968291321722eea3dc9234fa9c2e522fa6b Mon Sep 17 00:00:00 2001 From: Michael Yang Date: Sat, 20 Dec 2025 03:11:07 -0800 Subject: [PATCH 1/3] add missing typeclasses to doc --- lib/resolv.rb | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/resolv.rb b/lib/resolv.rb index fa7d4e2..b6ff348 100644 --- a/lib/resolv.rb +++ b/lib/resolv.rb @@ -487,13 +487,18 @@ def each_name(address) # * Resolv::DNS::Resource::IN::A # * Resolv::DNS::Resource::IN::AAAA # * Resolv::DNS::Resource::IN::ANY + # * Resolv::DNS::Resource::IN::CAA # * Resolv::DNS::Resource::IN::CNAME # * Resolv::DNS::Resource::IN::HINFO + # * Resolv::DNS::Resource::IN::HTTPS + # * Resolv::DNS::Resource::IN::LOC # * Resolv::DNS::Resource::IN::MINFO # * Resolv::DNS::Resource::IN::MX # * Resolv::DNS::Resource::IN::NS # * Resolv::DNS::Resource::IN::PTR # * Resolv::DNS::Resource::IN::SOA + # * Resolv::DNS::Resource::IN::SRV + # * Resolv::DNS::Resource::IN::SVCB # * Resolv::DNS::Resource::IN::TXT # * Resolv::DNS::Resource::IN::WKS # From 4bad8bccfcf23ab8ec7baa758874797ecaefa003 Mon Sep 17 00:00:00 2001 From: Michael Yang Date: Sat, 20 Dec 2025 03:23:56 -0800 Subject: [PATCH 2/3] add getresources test for every resource typeclass --- test/resolv/test_dns.rb | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/test/resolv/test_dns.rb b/test/resolv/test_dns.rb index 7a01909..5cf4087 100644 --- a/test/resolv/test_dns.rb +++ b/test/resolv/test_dns.rb @@ -942,4 +942,30 @@ def test_tcp_connection_closed_with_partial_message_body client_thread.join end end + + def test_every_resource_typeclass + Resolv::DNS.open do |dns| + [ + Resolv::DNS::Resource::IN::A, + Resolv::DNS::Resource::IN::AAAA, + Resolv::DNS::Resource::IN::ANY, + Resolv::DNS::Resource::IN::CAA, + Resolv::DNS::Resource::IN::CNAME, + Resolv::DNS::Resource::IN::HINFO, + Resolv::DNS::Resource::IN::HTTPS, + Resolv::DNS::Resource::IN::LOC, + Resolv::DNS::Resource::IN::MINFO, + Resolv::DNS::Resource::IN::MX, + Resolv::DNS::Resource::IN::NS, + Resolv::DNS::Resource::IN::PTR, + Resolv::DNS::Resource::IN::SOA, + Resolv::DNS::Resource::IN::SRV, + Resolv::DNS::Resource::IN::SVCB, + Resolv::DNS::Resource::IN::TXT, + Resolv::DNS::Resource::IN::WKS + ].each do |typeclass| + assert_instance_of(Array, dns.getresources("ruby-lang.org", typeclass)) + end + end + end end From 96e483d55bfa7320bc45377c8a02785c21c6691f Mon Sep 17 00:00:00 2001 From: Michael Yang Date: Fri, 16 Jan 2026 01:10:16 -0800 Subject: [PATCH 3/3] remove test for every class --- test/resolv/test_dns.rb | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/test/resolv/test_dns.rb b/test/resolv/test_dns.rb index 5cf4087..7a01909 100644 --- a/test/resolv/test_dns.rb +++ b/test/resolv/test_dns.rb @@ -942,30 +942,4 @@ def test_tcp_connection_closed_with_partial_message_body client_thread.join end end - - def test_every_resource_typeclass - Resolv::DNS.open do |dns| - [ - Resolv::DNS::Resource::IN::A, - Resolv::DNS::Resource::IN::AAAA, - Resolv::DNS::Resource::IN::ANY, - Resolv::DNS::Resource::IN::CAA, - Resolv::DNS::Resource::IN::CNAME, - Resolv::DNS::Resource::IN::HINFO, - Resolv::DNS::Resource::IN::HTTPS, - Resolv::DNS::Resource::IN::LOC, - Resolv::DNS::Resource::IN::MINFO, - Resolv::DNS::Resource::IN::MX, - Resolv::DNS::Resource::IN::NS, - Resolv::DNS::Resource::IN::PTR, - Resolv::DNS::Resource::IN::SOA, - Resolv::DNS::Resource::IN::SRV, - Resolv::DNS::Resource::IN::SVCB, - Resolv::DNS::Resource::IN::TXT, - Resolv::DNS::Resource::IN::WKS - ].each do |typeclass| - assert_instance_of(Array, dns.getresources("ruby-lang.org", typeclass)) - end - end - end end