Skip to content

Commit 7e121dc

Browse files
amatsudamatzbot
authored andcommitted
[ruby/logger] Another performance improvement on the Formatter by
using Kernel#sprintf over String#% (ruby/logger#75) * Prefer Kernel#sprintf over String#% for formatting Strings
1 parent 7ab4820 commit 7e121dc

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

lib/logger/formatter.rb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
class Logger
44
# Default formatter for log messages.
55
class Formatter
6-
Format = "%s, [%s #%d] %5s -- %s: %s\n"
6+
Format = "%.1s, [%s #%d] %5s -- %s: %s\n"
77
DatetimeFormat = "%Y-%m-%dT%H:%M:%S.%6N"
88

99
attr_accessor :datetime_format
@@ -13,8 +13,7 @@ def initialize
1313
end
1414

1515
def call(severity, time, progname, msg)
16-
Format % [severity[0, 1], format_datetime(time), Process.pid, severity, progname,
17-
msg2str(msg)]
16+
sprintf(Format, severity, format_datetime(time), Process.pid, severity, progname, msg2str(msg))
1817
end
1918

2019
private

0 commit comments

Comments
 (0)