From ddcf6a23a745430b5aac56c6ef9ab09b9132d9a2 Mon Sep 17 00:00:00 2001 From: Nazar Matus Date: Tue, 19 Jan 2021 15:47:38 +0200 Subject: [PATCH 1/2] Fix Ruby 2.5 incopatibility We don't really need that second optional argument, as its default value is just what we need https://ruby-doc.org/core-2.7.2/Module.html#method-i-private_method_defined-3F --- lib/ruby2_keywords.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ruby2_keywords.rb b/lib/ruby2_keywords.rb index 97cd081..7a3f2fa 100644 --- a/lib/ruby2_keywords.rb +++ b/lib/ruby2_keywords.rb @@ -1,5 +1,5 @@ class Module - unless private_method_defined?(:ruby2_keywords, true) + unless private_method_defined?(:ruby2_keywords) private # call-seq: # ruby2_keywords(method_name, ...) From 3a5fe66c9893755e28de8711be1ce3e9dd1d61bf Mon Sep 17 00:00:00 2001 From: Nazar Matus Date: Tue, 19 Jan 2021 16:07:37 +0200 Subject: [PATCH 2/2] Add Ruby 2.5 to the CI matrix --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b79ea7d..abe6e88 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -7,7 +7,7 @@ jobs: name: build (${{ matrix.ruby }} / ${{ matrix.os }}) strategy: matrix: - ruby: [ '3.0', 2.7, 2.6, head ] + ruby: [ '3.0', 2.7, 2.6, 2.5, head ] os: [ ubuntu-latest, macos-latest, windows-latest ] runs-on: ${{ matrix.os }} steps: