From f505e3f7cb07e5e2b06ebb60baf61b611cb27877 Mon Sep 17 00:00:00 2001
From: Nobuyoshi Nakada <nobu@ruby-lang.org>
Date: Sun, 25 Feb 2024 17:14:52 +0900
Subject: [PATCH] Use `IO.popen` to list files

- Redirect `git ls-files` without shelling out.

- When building by `gem`, `__FILE__` is the path name given in the
  command line, or the gemspec file name in the current directory.  In
  that case, comparison it and expanded path never equal.  Compare
  listed file names with the base name of `__FILE__` instead.
---
 tmpdir.gemspec | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tmpdir.gemspec b/tmpdir.gemspec
index 15fbd1d..d4bb892 100644
--- a/tmpdir.gemspec
+++ b/tmpdir.gemspec
@@ -15,9 +15,10 @@ Gem::Specification.new do |spec|
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files = Dir.chdir(__dir__) do
-    `git ls-files -z 2>#{IO::NULL}`.split("\x0").reject do |f|
-      (File.expand_path(f) == __FILE__) ||
+  gemspec = File.basename(__FILE__)
+  spec.files = IO.popen(%w[git ls-files -z], chdir: __dir__, err: IO::NULL) do |ls|
+    ls.readlines("\x0", chomp: true).reject do |f|
+      (f == gemspec) ||
         f.start_with?(*%w[bin/ test/ spec/ features/ .git Gemfile])
     end
   end