From e6b8196d8b8da893363a12c24b81371389a6b7ed Mon Sep 17 00:00:00 2001 From: James Mosier Date: Mon, 8 Oct 2018 09:51:31 -0400 Subject: [PATCH 1/2] allow for detaching of debugger --- src/debugger/main.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/debugger/main.ts b/src/debugger/main.ts index 03e82a6d9..8d0e02919 100644 --- a/src/debugger/main.ts +++ b/src/debugger/main.ts @@ -1,5 +1,6 @@ 'use strict'; +import { workspace } from 'vscode'; import {DebugSession, InitializedEvent, TerminatedEvent, StoppedEvent, BreakpointEvent, OutputEvent, Thread, StackFrame, Scope, Source, Handles, Breakpoint} from 'vscode-debugadapter'; import {DebugProtocol} from 'vscode-debugprotocol'; import {readFileSync,existsSync} from 'fs'; @@ -452,9 +453,11 @@ class RubyDebugSession extends DebugSession { } protected disconnectRequest(response: DebugProtocol.DisconnectResponse, args: DebugProtocol.DisconnectArguments) { + const detachDebugger = workspace.getConfiguration('ruby').detachDebugger && this.debugMode === Mode.attach; if (this.rubyProcess.state !== SocketClientState.closed) { - this.rubyProcess.Run('quit'); + this.rubyProcess.Run(detachDebugger ? 'detach' : 'quit'); } + this.sendResponse(response); } } From 21deb7cf6e5e94d3facc04f56615d4e70f2c1dd7 Mon Sep 17 00:00:00 2001 From: James Mosier Date: Mon, 8 Oct 2018 09:57:17 -0400 Subject: [PATCH 2/2] prettier formatting fix --- src/debugger/main.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/debugger/main.ts b/src/debugger/main.ts index 8d0e02919..8919a1d2e 100644 --- a/src/debugger/main.ts +++ b/src/debugger/main.ts @@ -1,6 +1,6 @@ 'use strict'; -import { workspace } from 'vscode'; +import {workspace} from 'vscode'; import {DebugSession, InitializedEvent, TerminatedEvent, StoppedEvent, BreakpointEvent, OutputEvent, Thread, StackFrame, Scope, Source, Handles, Breakpoint} from 'vscode-debugadapter'; import {DebugProtocol} from 'vscode-debugprotocol'; import {readFileSync,existsSync} from 'fs';