changed scenario run methods to run and run_async, updated parameter TypedDicts appropriately

Author: sid-rl

src/runloop_api_client/sdk/_types.py

@@ -175,5 +175,9 @@ class SDKScenarioListParams(ScenarioListParams, BaseRequestOptions):
     pass
 
 
-class SDKScenarioRunParams(ScenarioStartRunBaseParams, LongRequestOptions):
+class SDKScenarioRunAsyncParams(ScenarioStartRunBaseParams, LongRequestOptions):
     pass
+
+
+class SDKScenarioRunParams(ScenarioStartRunBaseParams, LongPollingRequestOptions):
+    pass

src/runloop_api_client/sdk/async_scenario.py

@@ -6,7 +6,7 @@
 from typing_extensions import Unpack, override
 
 from ..types import ScenarioView
-from ._types import BaseRequestOptions, LongRequestOptions, SDKScenarioRunParams
+from ._types import BaseRequestOptions, LongRequestOptions, SDKScenarioRunAsyncParams, SDKScenarioRunParams
 from .._client import AsyncRunloop
 from .async_scenario_run import AsyncScenarioRun
 
@@ -89,9 +89,9 @@ async def update(
             **options,
         )
 
-    async def run(
+    async def run_async(
         self,
-        **params: Unpack[SDKScenarioRunParams],
+        **params: Unpack[SDKScenarioRunAsyncParams],
     ) -> AsyncScenarioRun:
         """Start a new scenario run.
 
@@ -109,7 +109,7 @@ async def run(
         )
         return AsyncScenarioRun(self._client, run_view.id, run_view.devbox_id)
 
-    async def run_and_await_env_ready(
+    async def run(
         self,
         **params: Unpack[SDKScenarioRunParams],
     ) -> AsyncScenarioRun:

src/runloop_api_client/sdk/scenario.py

@@ -6,7 +6,7 @@
 from typing_extensions import Unpack, override
 
 from ..types import ScenarioView
-from ._types import BaseRequestOptions, LongRequestOptions, SDKScenarioRunParams
+from ._types import BaseRequestOptions, LongRequestOptions, SDKScenarioRunAsyncParams, SDKScenarioRunParams
 from .._client import Runloop
 from .scenario_run import ScenarioRun
 
@@ -89,9 +89,9 @@ def update(
             **options,
         )
 
-    def run(
+    def run_async(
         self,
-        **params: Unpack[SDKScenarioRunParams],
+        **params: Unpack[SDKScenarioRunAsyncParams],
     ) -> ScenarioRun:
         """Start a new scenario run.
 
@@ -109,7 +109,7 @@ def run(
         )
         return ScenarioRun(self._client, run_view.id, run_view.devbox_id)
 
-    def run_and_await_env_ready(
+    def run(
         self,
         **params: Unpack[SDKScenarioRunParams],
     ) -> ScenarioRun:

tests/sdk/test_async_scenario.py

@@ -50,7 +50,7 @@ async def test_run(self, mock_async_client: AsyncMock, scenario_run_view: MockSc
         mock_async_client.scenarios.start_run = AsyncMock(return_value=scenario_run_view)
 
         scenario = AsyncScenario(mock_async_client, "scn_123")
-        run = await scenario.run(run_name="test-run")
+        run = await scenario.run_async(run_name="test-run")
 
         assert run.id == "run_123"
         assert run.devbox_id == "dev_123"
@@ -66,7 +66,7 @@ async def test_run_and_await_env_ready(
         mock_async_client.scenarios.start_run_and_await_env_ready = AsyncMock(return_value=scenario_run_view)
 
         scenario = AsyncScenario(mock_async_client, "scn_123")
-        run = await scenario.run_and_await_env_ready(run_name="test-run")
+        run = await scenario.run(run_name="test-run")
 
         assert run.id == "run_123"
         assert run.devbox_id == "dev_123"

tests/sdk/test_scenario.py

@@ -50,7 +50,7 @@ def test_run(self, mock_client: Mock, scenario_run_view: MockScenarioRunView) ->
         mock_client.scenarios.start_run.return_value = scenario_run_view
 
         scenario = Scenario(mock_client, "scn_123")
-        run = scenario.run(run_name="test-run")
+        run = scenario.run_async(run_name="test-run")
 
         assert run.id == "run_123"
         assert run.devbox_id == "dev_123"
@@ -64,7 +64,7 @@ def test_run_and_await_env_ready(self, mock_client: Mock, scenario_run_view: Moc
         mock_client.scenarios.start_run_and_await_env_ready.return_value = scenario_run_view
 
         scenario = Scenario(mock_client, "scn_123")
-        run = scenario.run_and_await_env_ready(run_name="test-run")
+        run = scenario.run(run_name="test-run")
 
         assert run.id == "run_123"
         assert run.devbox_id == "dev_123"

tests/smoketests/sdk/test_async_scenario.py

@@ -85,7 +85,7 @@ async def test_scenario_run_lifecycle(self, async_sdk_client: AsyncRunloopSDK) -
         scenario = scenarios[0]
 
         # Start a run
-        run = await scenario.run(run_name="sdk-smoketest-async-run")
+        run = await scenario.run_async(run_name="sdk-smoketest-async-run")
 
         try:
             assert run.id is not None
@@ -121,7 +121,7 @@ async def test_scenario_run_and_await_env_ready(self, async_sdk_client: AsyncRun
         scenario = scenarios[0]
 
         # Start a run and wait for environment in one call
-        run = await scenario.run_and_await_env_ready(run_name="sdk-smoketest-async-await")
+        run = await scenario.run(run_name="sdk-smoketest-async-await")
 
         try:
             assert run.id is not None

tests/smoketests/sdk/test_scenario.py

@@ -85,7 +85,7 @@ def test_scenario_run_lifecycle(self, sdk_client: RunloopSDK) -> None:
         scenario = scenarios[0]
 
         # Start a run
-        run = scenario.run(run_name="sdk-smoketest-run")
+        run = scenario.run_async(run_name="sdk-smoketest-run")
 
         try:
             assert run.id is not None
@@ -121,7 +121,7 @@ def test_scenario_run_and_await_env_ready(self, sdk_client: RunloopSDK) -> None:
         scenario = scenarios[0]
 
         # Start a run and wait for environment in one call
-        run = scenario.run_and_await_env_ready(run_name="sdk-smoketest-await")
+        run = scenario.run(run_name="sdk-smoketest-await")
 
         try:
             assert run.id is not None