Do not make local copy of inline(always) fns in debug mode

Author: spastorino

compiler/rustc_middle/src/mir/mono.rs

@@ -107,12 +107,14 @@ impl<'tcx> MonoItem<'tcx> {
                 }
 
                 // Finally, if this is `#[inline(always)]` we're sure to respect
-                // that with an inline copy per CGU, but otherwise we'll be
-                // creating one copy of this `#[inline]` function which may
-                // conflict with upstream crates as it could be an exported
-                // symbol.
+                // that (unless in OptLevel::No) with an inline copy per CGU,
+                // but otherwise we'll be creating one copy of this `#[inline]`
+                // function which may conflict with upstream crates as it could
+                // be an exported symbol.
                 match tcx.codegen_fn_attrs(instance.def_id()).inline {
-                    InlineAttr::Always => InstantiationMode::LocalCopy,
+                    InlineAttr::Always if tcx.sess.opts.optimize != OptLevel::No => {
+                        InstantiationMode::LocalCopy
+                    }
                     _ => InstantiationMode::GloballyShared { may_conflict: true },
                 }
             }

src/test/run-make-fulldeps/inline-always-many-cgu/Makefile

@@ -1,7 +1,12 @@
 -include ../tools.mk
 
 all:
-	$(RUSTC) foo.rs --emit llvm-ir -C codegen-units=2
+	$(RUSTC) foo.rs --emit llvm-ir -C codegen-units=2 -C opt-level=0
+	if ![cat $(TMPDIR)/*.ll | $(CGREP) -e '\bcall\b']; then \
+		echo "not found call instruction when one was expected"; \
+		exit 1; \
+	fi
+	$(RUSTC) foo.rs --emit llvm-ir -C codegen-units=2 -C opt-level=1
 	if cat $(TMPDIR)/*.ll | $(CGREP) -e '\bcall\b'; then \
 		echo "found call instruction when one wasn't expected"; \
 		exit 1; \